Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1344993002: Refactor isolate interrupts to use OOB messages instead of interrupt bits. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review 2 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/pause_idle_isolate_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/debugger.dart
diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart
index 66c960987911fdb5750ba2ea4854b2000867c166..8c1a2ed69da5ed4dcca2e9db5328103174002aad 100644
--- a/runtime/observatory/lib/src/elements/debugger.dart
+++ b/runtime/observatory/lib/src/elements/debugger.dart
@@ -1358,10 +1358,12 @@ class ObservatoryDebugger extends Debugger {
void _reportPause(ServiceEvent event) {
if (event.kind == ServiceEvent.kPauseStart) {
console.print(
- "Paused at isolate start (type 'continue' [F7] or 'step' [F10] to start the isolate')");
+ "Paused at isolate start "
+ "(type 'continue' [F7] or 'step' [F10] to start the isolate')");
} else if (event.kind == ServiceEvent.kPauseExit) {
console.print(
- "Paused at isolate exit (type 'continue' or [F7] to exit the isolate')");
+ "Paused at isolate exit "
+ "(type 'continue' or [F7] to exit the isolate')");
}
if (stack['frames'].length > 0) {
Frame frame = stack['frames'][0];
@@ -1384,6 +1386,9 @@ class ObservatoryDebugger extends Debugger {
console.print('Paused at ${script.name}:${line}:${col}');
}
});
+ } else {
+ console.print("Paused in message loop (type 'continue' or [F7] "
+ "to resume processing messages)");
}
}
« no previous file with comments | « no previous file | runtime/observatory/tests/service/pause_idle_isolate_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698