Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344933002: Clean up some unused methods from ApplicationManager (Closed)

Created:
5 years, 3 months ago by Ben Goodger (Google)
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up some unused methods from ApplicationManager R=jam@chromium.org BUG= Committed: https://crrev.com/f7615c1f1679ed6bcac5c562b28bc0994c79c794 Cr-Commit-Position: refs/heads/master@{#349175}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -230 lines) Patch
M mojo/runner/android/android_handler.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 2 3 4 5 chunks +6 lines, -9 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 2 3 4 5 1 chunk +5 lines, -7 lines 0 comments Download
M mojo/runner/android/bootstrap.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/runner/android/run_android_application_function.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/runner/child_process_host.h View 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/runner/child_process_host.cc View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/runner/child_process_host_unittest.cc View 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/context.cc View 1 2 3 4 5 2 chunks +0 lines, -20 lines 0 comments Download
M mojo/runner/in_process_native_runner.h View 3 chunks +1 line, -3 lines 0 comments Download
M mojo/runner/in_process_native_runner.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M mojo/runner/native_application_support.h View 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/runner/native_application_support.cc View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 3 2 chunks +1 line, -2 lines 0 comments Download
M mojo/runner/out_of_process_native_runner.h View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/runner/out_of_process_native_runner.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M mojo/runner/switches.h View 3 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/switches.cc View 3 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/shell/application_manager.h View 3 6 chunks +1 line, -21 lines 0 comments Download
M mojo/shell/application_manager.cc View 3 5 chunks +3 lines, -47 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 3 3 chunks +7 lines, -47 lines 0 comments Download
M mojo/shell/native_runner.h View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Ben Goodger (Google)
5 years, 3 months ago (2015-09-15 20:10:17 UTC) #1
jam
lgtm
5 years, 3 months ago (2015-09-15 20:25:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344933002/80001
5 years, 3 months ago (2015-09-16 15:25:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/133185)
5 years, 3 months ago (2015-09-16 15:43:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344933002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344933002/100001
5 years, 3 months ago (2015-09-16 16:53:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/108032)
5 years, 3 months ago (2015-09-16 18:11:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344933002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344933002/100001
5 years, 3 months ago (2015-09-16 18:13:20 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-16 18:57:51 UTC) #15
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/f7615c1f1679ed6bcac5c562b28bc0994c79c794 Cr-Commit-Position: refs/heads/master@{#349175}
5 years, 3 months ago (2015-09-16 18:58:47 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:58:39 UTC) #17
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/f7615c1f1679ed6bcac5c562b28bc0994c79c794
Cr-Commit-Position: refs/heads/master@{#349175}

Powered by Google App Engine
This is Rietveld 408576698