Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 134493002: disable assert for now (Closed)

Created:
6 years, 11 months ago by reed1
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

disable assert for now BUG=skia:2012

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/core/SkBitmap.cpp View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
reed1
6 years, 11 months ago (2014-01-10 18:41:22 UTC) #1
hal.canary
https://codereview.chromium.org/134493002/diff/1/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/134493002/diff/1/src/core/SkBitmap.cpp#newcode1055 src/core/SkBitmap.cpp:1055: // https://code.google.com/p/skia/issues/detail?id=2012 Should we put in some less strict ...
6 years, 11 months ago (2014-01-10 18:46:09 UTC) #2
bsalomon
lgtm until we figure out a larger fix (e.g. should we just make a new ...
6 years, 11 months ago (2014-01-10 19:06:06 UTC) #3
scroggo
On 2014/01/10 19:06:06, bsalomon wrote: > lgtm until we figure out a larger fix (e.g. ...
6 years, 11 months ago (2014-01-10 20:55:53 UTC) #4
scroggo
6 years, 11 months ago (2014-01-15 17:08:44 UTC) #5
On 2014/01/10 20:55:53, scroggo wrote:
> On 2014/01/10 19:06:06, bsalomon wrote:
> > lgtm until we figure out a larger fix (e.g. should we just make a new pixel
> ref
> > for the copy rather than memcpying). This seems to raise a bunch of
questions
> > around the semantics of bitmap copying.
> 
> The original CL was reverted, but I have updated
> https://codereview.chromium.org/112113005/ to include the fix from this one.

The other CL was relanded, with the changes suggested here. I'll add a summary
of the issue in https://code.google.com/p/skia/issues/detail?id=2012

Powered by Google App Engine
This is Rietveld 408576698