Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 13449003: [OTS] Make standalone tools compile on Mac (Closed)

Created:
7 years, 8 months ago by Kunihiko Sakamoto
Modified:
7 years, 8 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Visibility:
Public.

Description

[OTS] Make standalone tools compile on Mac - ATS Fonts is deprecated. Use CTFont instead. - Removed an unused function. Review URL: https://codereview.chromium.org/13449003/ Committed: 99

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -142 lines) Patch
M src/cff_type2_charstring.cc View 1 1 chunk +0 lines, -102 lines 0 comments Download
M test/idempotent.cc View 1 chunk +10 lines, -18 lines 0 comments Download
M test/validator-checker.cc View 1 chunk +10 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kunihiko Sakamoto
Yusuke-san, could you take a look?
7 years, 8 months ago (2013-04-03 06:00:57 UTC) #1
Yusuke Sato
https://codereview.chromium.org/13449003/diff/1/src/cff_type2_charstring.cc File src/cff_type2_charstring.cc (right): https://codereview.chromium.org/13449003/diff/1/src/cff_type2_charstring.cc#newcode41 src/cff_type2_charstring.cc:41: // TODO(ksakamoto): Remove the below function (looks like unused ...
7 years, 8 months ago (2013-04-03 07:40:32 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/13449003/diff/1/src/cff_type2_charstring.cc File src/cff_type2_charstring.cc (right): https://codereview.chromium.org/13449003/diff/1/src/cff_type2_charstring.cc#newcode41 src/cff_type2_charstring.cc:41: // TODO(ksakamoto): Remove the below function (looks like unused ...
7 years, 8 months ago (2013-04-03 08:18:04 UTC) #3
Yusuke Sato
lgtm On 2013/04/03 08:18:04, ksakamoto wrote: > https://codereview.chromium.org/13449003/diff/1/src/cff_type2_charstring.cc > File src/cff_type2_charstring.cc (right): > > https://codereview.chromium.org/13449003/diff/1/src/cff_type2_charstring.cc#newcode41 ...
7 years, 8 months ago (2013-04-03 08:22:52 UTC) #4
Kunihiko Sakamoto
7 years, 8 months ago (2013-04-03 08:32:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698