src/symbol.js - Issue 1344893002: [builtins] Unify the String constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/symbol.js

Issue 1344893002: [builtins] Unify the String constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/symbol.js

diff --git a/src/symbol.js b/src/symbol.js

index 2f68eff24197a6354d70905baf7422f8635dc598..c65cda7c475e5b75adff206a08ea5126d29d6cd3 100644

--- a/src/symbol.js

+++ b/src/symbol.js

@@ -53,8 +53,7 @@ function SymbolToString() {

throw MakeTypeError(kIncompatibleMethodReceiver,

"Symbol.prototype.toString", this);

}

- var description = %SymbolDescription(%_ValueOf(this));

- return "Symbol(" + (IS_UNDEFINED(description) ? "" : description) + ")";

+ return %SymbolDescriptiveString(%_ValueOf(this));

}

« no previous file with comments | « src/string.js ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »