Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 1344853002: Teach the network service to clear its disk cache if requested. (Closed)

Created:
5 years, 3 months ago by ppi
Modified:
5 years, 3 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/monet.git@master
Target Ref:
refs/heads/master
Project:
monet
Visibility:
Public.

Description

Teach the network service to clear its disk cache if requested. Fixes domokit/mojo#420. R=qsr@chromium.org Committed: https://github.com/domokit/monet37e467ca237463770d2e29f2f4f006add368929b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Use a one-off background thread. #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : Address Ben's comments. #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 2

Patch Set 8 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M mojo/services/network/network_context.h View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/services/network/network_context.cc View 1 2 3 4 5 6 7 4 chunks +32 lines, -1 line 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ppi
Hi Ben, ptal.
5 years, 3 months ago (2015-09-15 13:35:19 UTC) #1
ppi
Updated to use one-off base::Thread as discussed offline, ptal.
5 years, 3 months ago (2015-09-15 17:18:21 UTC) #2
qsr
https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/network_context.h File mojo/services/network/network_context.h (right): https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/network_context.h#newcode37 mojo/services/network/network_context.h:37: NetworkContext(const base::FilePath& base_path); Why did you remove this explicit? ...
5 years, 3 months ago (2015-09-16 13:27:05 UTC) #3
ppi
https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/network_context.h File mojo/services/network/network_context.h (right): https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/network_context.h#newcode37 mojo/services/network/network_context.h:37: NetworkContext(const base::FilePath& base_path); On 2015/09/16 13:27:05, qsr wrote: > ...
5 years, 3 months ago (2015-09-16 14:20:59 UTC) #4
qsr
LGTM with nits. https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/network_context.h File mojo/services/network/network_context.h (right): https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/network_context.h#newcode35 mojo/services/network/network_context.h:35: base::Closure clear_finished_callback); const base::Closure&
5 years, 3 months ago (2015-09-16 14:23:19 UTC) #5
ppi
https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/network_context.h File mojo/services/network/network_context.h (right): https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/network_context.h#newcode35 mojo/services/network/network_context.h:35: base::Closure clear_finished_callback); On 2015/09/16 14:23:19, qsr wrote: > const ...
5 years, 3 months ago (2015-09-16 14:29:16 UTC) #6
ppi
5 years, 3 months ago (2015-09-16 14:29:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #8 (id:140001) manually as
37e467ca237463770d2e29f2f4f006add368929b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698