Teach the network service to clear its disk cache if requested.

Teach the network service to clear its disk cache if requested.

Fixes domokit/mojo#420.

R=qsr@chromium.org

Committed: https://github.com/domokit/monet37e467ca237463770d2e29f2f4f006add368929b

[ppi, 2015-09-15 13:35:19]

Hi Ben,

ptal.

[ppi, 2015-09-15 17:18:21]

Updated to use one-off base::Thread as discussed offline, ptal.

[qsr, 2015-09-16 13:27:05]

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
File mojo/services/network/network_context.h (right):

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
mojo/services/network/network_context.h:37: NetworkContext(const base::FilePath&
base_path);
Why did you remove this explicit?

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
File mojo/services/network/network_service_delegate.cc (right):

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
mojo/services/network/network_service_delegate.cc:47:
base::Owned(cache_delete_thread.release())));
This seems hacky. Where is the guarantee that ClearCache should only post a
single task? If you start posting task in the thread, this will break badly.

ClearCache should take a callback.

[ppi, 2015-09-16 14:20:59]

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
File mojo/services/network/network_context.h (right):

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
mojo/services/network/network_context.h:37: NetworkContext(const base::FilePath&
base_path);
On 2015/09/16 13:27:05, qsr wrote:
> Why did you remove this explicit?

accident:). Done.

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
File mojo/services/network/network_service_delegate.cc (right):

https://codereview.chromium.org/1344853002/diff/60001/mojo/services/network/n...
mojo/services/network/network_service_delegate.cc:47:
base::Owned(cache_delete_thread.release())));
On 2015/09/16 13:27:05, qsr wrote:
> This seems hacky. Where is the guarantee that ClearCache should only post a
> single task? If you start posting task in the thread, this will break badly.
> 
> ClearCache should take a callback.

Done.

[qsr, 2015-09-16 14:23:19]

LGTM with nits.

https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/...
File mojo/services/network/network_context.h (right):

https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/...
mojo/services/network/network_context.h:35: base::Closure
clear_finished_callback);
const base::Closure&

[ppi, 2015-09-16 14:29:16]

https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/...
File mojo/services/network/network_context.h (right):

https://codereview.chromium.org/1344853002/diff/120001/mojo/services/network/...
mojo/services/network/network_context.h:35: base::Closure
clear_finished_callback);
On 2015/09/16 14:23:19, qsr wrote:
> const base::Closure&

Done.

[ppi, 2015-09-16 14:29:30]

Committed patchset #8 (id:140001) manually as
37e467ca237463770d2e29f2f4f006add368929b (presubmit successful).