content/common/background_sync_service.mojom - Issue 1344843003: [BackgroundSync] Add browser side support for SyncRegistration.done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/background_sync_service.mojom

Issue 1344843003: [BackgroundSync] Add browser side support for SyncRegistration.done (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ncn_max

Patch Set: Address comments from PS7 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/background_sync/background_sync_provider_thread_proxy.cc ('k') | content/test/data/background_sync/background_sync_test_helpers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/background_sync_service.mojom

diff --git a/content/common/background_sync_service.mojom b/content/common/background_sync_service.mojom

index 8b2f8b4ee642f78f570e0e89f5a3d49f30fa3919..b4c9b935c66bb80631f2855b64f9bb24dcea64f2 100644

--- a/content/common/background_sync_service.mojom

+++ b/content/common/background_sync_service.mojom

@@ -20,7 +20,10 @@ enum BackgroundSyncError {

enum BackgroundSyncState {

PENDING,

FIRING,

- FAILED

+ UNREGISTERED_WHILE_FIRING,

+ FAILED,

+ SUCCESS,

+ UNREGISTERED

};

interface BackgroundSyncService {

@@ -41,6 +44,7 @@ interface BackgroundSyncService {

DuplicateRegistrationHandle(int32 handle_id)

=> (BackgroundSyncError err, SyncRegistration? registration);

ReleaseRegistration(int32 handle_id);

+ NotifyWhenDone(int32 handle_id) => (BackgroundSyncError err, BackgroundSyncState final_status);

};

interface BackgroundSyncServiceClient {