content/child/background_sync/background_sync_provider_thread_proxy.h - Issue 1344843003: [BackgroundSync] Add browser side support for SyncRegistration.done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/background_sync/background_sync_provider_thread_proxy.h

Issue 1344843003: [BackgroundSync] Add browser side support for SyncRegistration.done (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ncn_max

Patch Set: Address comments from PS7 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/background_sync/background_sync_provider.cc ('k') | content/child/background_sync/background_sync_provider_thread_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/background_sync/background_sync_provider_thread_proxy.h

diff --git a/content/child/background_sync/background_sync_provider_thread_proxy.h b/content/child/background_sync/background_sync_provider_thread_proxy.h

index 7aed6d73df615417b4d6846827f6d0dfe9d2d7ab..ae460ab46756fcc177574bafc13e3073a1781bbc 100644

--- a/content/child/background_sync/background_sync_provider_thread_proxy.h

+++ b/content/child/background_sync/background_sync_provider_thread_proxy.h

@@ -59,6 +59,9 @@ class BackgroundSyncProviderThreadProxy : public blink::WebSyncProvider,

blink::WebServiceWorkerRegistration* service_worker_registration,

blink::WebSyncGetPermissionStatusCallbacks* callbacks) override;

void releaseRegistration(int64_t handle_id) override;

+ void notifyWhenDone(

+ int64_t handle_id,

+ blink::WebSyncNotifyWhenDoneCallbacks* callbacks) override;

// Given |handle_id|, ask the provider for a new handle with the same

// underlying registration.