content/browser/background_sync/background_sync_service_impl.h - Issue 1344843003: [BackgroundSync] Add browser side support for SyncRegistration.done

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_service_impl.h

Issue 1344843003: [BackgroundSync] Add browser side support for SyncRegistration.done (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ncn_max

Patch Set: Address comments from PS7 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_registration_handle.cc ('k') | content/browser/background_sync/background_sync_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_service_impl.h

diff --git a/content/browser/background_sync/background_sync_service_impl.h b/content/browser/background_sync/background_sync_service_impl.h

index 7e17b7f0b68f7b193184aac0c449ae420aa5372e..f00c668d4260e38138ddf5eda18f70a3cea92df9 100644

--- a/content/browser/background_sync/background_sync_service_impl.h

+++ b/content/browser/background_sync/background_sync_service_impl.h

@@ -53,6 +53,8 @@ class CONTENT_EXPORT BackgroundSyncServiceImpl

const DuplicateRegistrationHandleCallback& callback) override;

void ReleaseRegistration(

BackgroundSyncRegistrationHandle::HandleId handle_id) override;

+ void NotifyWhenDone(BackgroundSyncRegistrationHandle::HandleId handle_id,

+ const NotifyWhenDoneCallback& callback) override;

void OnRegisterResult(const RegisterCallback& callback,

BackgroundSyncStatus status,

@@ -63,6 +65,9 @@ class CONTENT_EXPORT BackgroundSyncServiceImpl

const GetRegistrationsCallback& callback,

BackgroundSyncStatus status,

scoped_ptr<ScopedVector<BackgroundSyncRegistrationHandle>> result);

+ void OnNotifyWhenDoneResult(const NotifyWhenDoneCallback& callback,

+ BackgroundSyncStatus status,

+ BackgroundSyncState sync_state);

// Called when an error is detected on binding_.

void OnConnectionError();