[BackgroundSync] Add browser side support for SyncRegistration.done

content/browser/background_sync/background_sync_service_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_sync/background_sync_service_impl.h"
 
 #include "background_sync_registration_handle.h"
 #include "base/memory/weak_ptr.h"
 #include "base/stl_util.h"
 #include "content/browser/background_sync/background_sync_context_impl.h"
@@ skipping 209 matching lines @@
     BackgroundSyncRegistrationHandle::HandleId handle_id) {
   if (!active_handles_.Lookup(handle_id)) {
     // TODO(jkarlin): Abort client.
     LOG(WARNING) << "Client attempted to release non-existing registration";
     return;
   }
 
   active_handles_.Remove(handle_id);
 }
 
+void BackgroundSyncServiceImpl::NotifyWhenDone(
+    BackgroundSyncRegistrationHandle::HandleId handle_id,
+    const NotifyWhenDoneCallback& callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  BackgroundSyncRegistrationHandle* registration =
+      active_handles_.Lookup(handle_id);
+  if (!registration) {
+    callback.Run(BACKGROUND_SYNC_ERROR_NOT_ALLOWED,
+                 BACKGROUND_SYNC_STATE_FAILED);

[iclelland, 2015/09/17 13:48:09]

Why FAILED here? I expected to see something like UNREGISTERED, unless that
actually implies something different.

[jkarlin, 2015/09/17 17:40:25]

If there is no active handle then the javascript attempted to call done on a
registration that it shouldn't have been able to have an id for.

+    return;
+  }
+
+  registration->NotifyWhenDone(
+      base::Bind(&BackgroundSyncServiceImpl::OnNotifyWhenDoneResult,
+                 weak_ptr_factory_.GetWeakPtr(), callback));
+}
+
 void BackgroundSyncServiceImpl::OnRegisterResult(
     const RegisterCallback& callback,
     BackgroundSyncStatus status,
     scoped_ptr<BackgroundSyncRegistrationHandle> result) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   BackgroundSyncRegistrationHandle* result_ptr = result.get();
 
   if (status != BACKGROUND_SYNC_STATUS_OK) {
     callback.Run(static_cast<content::BackgroundSyncError>(status),
                  SyncRegistrationPtr(content::SyncRegistration::New()));
@@ skipping 24 matching lines @@
     active_handles_.AddWithID(registration, registration->handle_id());
     mojo_registrations.push_back(ToMojoRegistration(*registration));
   }
 
   result_registrations->weak_clear();
 
   callback.Run(static_cast<content::BackgroundSyncError>(status),
                mojo_registrations.Pass());
 }
 
+void BackgroundSyncServiceImpl::OnNotifyWhenDoneResult(
+    const NotifyWhenDoneCallback& callback,
+    BackgroundSyncStatus status,
+    BackgroundSyncState sync_state) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  callback.Run(static_cast<content::BackgroundSyncError>(status), sync_state);
+}
+
 }  // namespace content