Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1344843002: Let's try building the example app on the bots too. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Let's try building the example app on the bots too. BUG=skia:4269 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/935121bd41a09552394ebbab43408e2b0c1ec8f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cmake/cmake_build View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
mtklein
5 years, 3 months ago (2015-09-15 12:45:19 UTC) #2
mtklein_C
Whoops, sending from @chromium.org.
5 years, 3 months ago (2015-09-15 12:47:57 UTC) #4
borenet
LGTM. I think the trybot should've showed up by now as well...
5 years, 3 months ago (2015-09-15 12:49:12 UTC) #5
mtklein_C
On 2015/09/15 12:49:12, borenet wrote: > LGTM. I think the trybot should've showed up by ...
5 years, 3 months ago (2015-09-15 12:50:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344843002/1
5 years, 3 months ago (2015-09-15 12:51:11 UTC) #8
mtklein
> Let's find out. Added to CQ_EXTRA_TRYBOTS. Yep!
5 years, 3 months ago (2015-09-15 12:55:52 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 13:07:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/935121bd41a09552394ebbab43408e2b0c1ec8f7

Powered by Google App Engine
This is Rietveld 408576698