Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1344803002: [MIPS] GN: Disable NaCl for MIPS (Closed)

Created:
5 years, 3 months ago by gordanac
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, gordanac
CC:
chromium-reviews, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MIPS] GN: Disable NaCl for MIPS Few more changes need to go in before enabling NaCl support for MIPS, lets have it disabled until then. TEST=Build Chromium using GN. BUG=130022 Committed: https://crrev.com/d82b297171f8a108efd23929927009d4874548cf Cr-Commit-Position: refs/heads/master@{#349109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/config/features.gni View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
gordanac
Please take a look. NaCl is not yet supported in Chromium for MIPS. Enabling NaCl ...
5 years, 3 months ago (2015-09-15 10:32:15 UTC) #2
gordanac
I have updated the description as per the actual NaCl status for MIPS: just few ...
5 years, 3 months ago (2015-09-15 13:28:59 UTC) #3
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-15 18:21:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344803002/1
5 years, 3 months ago (2015-09-16 08:14:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_chromeos_rel on ...
5 years, 3 months ago (2015-09-16 08:27:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344803002/1
5 years, 3 months ago (2015-09-16 12:54:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 13:21:41 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d82b297171f8a108efd23929927009d4874548cf Cr-Commit-Position: refs/heads/master@{#349109}
5 years, 3 months ago (2015-09-16 13:22:32 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:55:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d82b297171f8a108efd23929927009d4874548cf
Cr-Commit-Position: refs/heads/master@{#349109}

Powered by Google App Engine
This is Rietveld 408576698