Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1344793002: X87: [builtins] Remove the weird STACK_OVERFLOW builtin. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Remove the weird STACK_OVERFLOW builtin. port 39604dda567b9ba9f4dcfe42f95471f30ec7cb6b (r30693). original commit message: Just use a %ThrowStackOverflow runtime function instead, which does the trick, especially since the Isolate already has a preallocated StackOverflow error for that. BUG= Committed: https://crrev.com/ee86a749bf0db6c749b4487fc50fe763f73c7f39 Cr-Commit-Position: refs/heads/master@{#30741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal.
5 years, 3 months ago (2015-09-15 10:15:07 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-15 10:35:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344793002/1
5 years, 3 months ago (2015-09-15 10:35:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 11:31:19 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:31:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee86a749bf0db6c749b4487fc50fe763f73c7f39
Cr-Commit-Position: refs/heads/master@{#30741}

Powered by Google App Engine
This is Rietveld 408576698