Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 1344783002: ServiceWorker: Carve out methods of ServiceWorkerProviderContext to delegate classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add class comments more Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_network_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index 7419a2b8e07ff9a697284f67bbf902484c426b06..7e7dfe858f1ff200a3f36ceee5b71ab7beea9a2e 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -348,9 +348,6 @@ ServiceWorkerDispatcher::GetOrAdoptRegistration(
// We can assume that this message handler is called before the worker context
// starts because script loading happens after this association.
-// TODO(nhiroki): This association information could be pushed into
-// EmbeddedWorkerMsg_StartWorker message and handed over to the worker thread
-// without a lock in ServiceWorkerProviderContext.
void ServiceWorkerDispatcher::OnAssociateRegistrationWithServiceWorker(
int thread_id,
int provider_id,
@@ -362,9 +359,6 @@ void ServiceWorkerDispatcher::OnAssociateRegistrationWithServiceWorker(
if (context == provider_contexts_.end())
return;
context->second->OnAssociateRegistration(info, attrs);
-
- // We don't have to add entries into |worker_to_provider_| because state
- // change events for the workers will be notified on the worker thread.
}
void ServiceWorkerDispatcher::OnAssociateRegistration(
« no previous file with comments | « no previous file | content/child/service_worker/service_worker_network_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698