Source/core/css/StyleInvalidationAnalysis.cpp - Issue 134473008: Remove CSS regions support, keeping a bare minimum to support "region-based" multicol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StyleInvalidationAnalysis.cpp

Issue 134473008: Remove CSS regions support, keeping a bare minimum to support "region-based" multicol. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review: Revert changes in Source/devtools/Inspector-1.1.json Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/StyleInvalidationAnalysis.cpp

diff --git a/Source/core/css/StyleInvalidationAnalysis.cpp b/Source/core/css/StyleInvalidationAnalysis.cpp

index ac2a0bf2f352562fdaadb82148f5b4f58bd8e969..bc5942503f1f2263c77ac06c9dfa5733d61e56b8 100644

--- a/Source/core/css/StyleInvalidationAnalysis.cpp

+++ b/Source/core/css/StyleInvalidationAnalysis.cpp

@@ -127,7 +127,6 @@ static bool ruleAdditionMightRequireDocumentStyleRecalc(StyleRuleBase* rule)

case StyleRule::Supports: // If we evaluated the supports-clause we could avoid recalc.

case StyleRule::Viewport: // If the viewport doesn't match, we could avoid recalcing.

// FIXME: Unclear if any of the rest need to cause style recalc:

- case StyleRule::Region:

case StyleRule::Filter:

return true;

« no previous file with comments | « Source/core/css/RuntimeCSSEnabled.cpp ('k') | Source/core/css/StylePropertySet.cpp » ('j') | Source/core/dom/Node.h » ('J')