Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 134473003: Disable flaky AutofillDialogControllerTest.SimulateSuccessfulSignIn on XP. (Closed)

Created:
6 years, 11 months ago by msw
Modified:
6 years, 11 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Disable flaky AutofillDialogControllerTest.SimulateSuccessfulSignIn on XP. AutofillDialogControllerTest.SimulateSuccessfulSignIn is flaky on Windows XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/25976 It fails on that run, but then passes on builds 25977, 25978, and 25979. It might be related to my r244436, I'll disable on XP for now and investigate later. BUG=333641 TEST=NONE TBR=dbeam@chromium.org,estade@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/134473003/1
6 years, 11 months ago (2014-01-12 18:27:28 UTC) #1
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 18:27:40 UTC) #2
Message was sent while issue was closed.
Change committed as 244447

Powered by Google App Engine
This is Rietveld 408576698