Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 134473002: Pull in Chromium's version of GatherPixelRefs (Closed)

Created:
6 years, 11 months ago by robertphillips
Modified:
6 years, 11 months ago
Reviewers:
reed1
CC:
skia-team_googlegroups.com
Visibility:
Public.

Description

Pull in Chromium's version of GatherPixelRefs

Patch Set 1 #

Patch Set 2 : cleaned up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+661 lines, -75 lines) Patch
M gyp/utils.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M include/utils/SkPictureUtils.h View 1 2 chunks +52 lines, -0 lines 0 comments Download
A src/utils/SkGatherPixelRefsAndRects.h View 1 1 chunk +353 lines, -0 lines 0 comments Download
A src/utils/SkGatherPixelRefsAndRects.cpp View 1 1 chunk +25 lines, -0 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PictureTest.cpp View 1 15 chunks +227 lines, -75 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 11 months ago (2014-01-10 19:01:48 UTC) #1
reed1
do we still need GatherPixelRefs anymore?
6 years, 11 months ago (2014-01-10 19:08:55 UTC) #2
robertphillips
Long term probably not. Short term, I would like to keep both: the next step ...
6 years, 11 months ago (2014-01-10 19:11:40 UTC) #3
reed1
lgtm
6 years, 11 months ago (2014-01-10 19:13:22 UTC) #4
robertphillips
6 years, 11 months ago (2014-01-13 13:33:44 UTC) #5
Message was sent while issue was closed.
committed as r13038

Powered by Google App Engine
This is Rietveld 408576698