Include implicit_cast.h at all users of it.

Include implicit_cast.h at all users of it.

The implicit_cast in base will be no more, make sure we have a reference
to the crashpad version at all callsites.

BUG=529769, 472900, crashpad:51
R=mark@chromium.org, scottmg@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/0b022d72a2a4f9b89fcd4ab6aeabc92efa93a0c2

[danakj, 2015-09-14 21:37:16]

danakj@chromium.org changed reviewers:
+ mark@chromium.org, scottmg@chromium.org

[danakj, 2015-09-14 21:37:17]

I missed a lot of callsites, woops. PTAL

[scottmg, 2015-09-14 21:40:26]

Oops, sorry. Your previous CL built fine for me, but I guess that's because I
had a mini_chromium base with implicit_cast still?

[scottmg, 2015-09-14 21:41:54]

https://codereview.chromium.org/1344683002/diff/1/util/numeric/checked_range.h
File util/numeric/checked_range.h (right):

https://codereview.chromium.org/1344683002/diff/1/util/numeric/checked_range....
util/numeric/checked_range.h:22: #include "util/misc/implicit_cast.h"
sorting

[danakj, 2015-09-14 21:42:24]

https://codereview.chromium.org/1344683002/diff/1/util/numeric/checked_range.h
File util/numeric/checked_range.h (right):

https://codereview.chromium.org/1344683002/diff/1/util/numeric/checked_range....
util/numeric/checked_range.h:22: #include "util/misc/implicit_cast.h"
On 2015/09/14 21:41:54, scottmg wrote:
> sorting

oops what was i doing. fixed.

[Mark Mentovai, 2015-09-14 21:44:03]

LGTM. I hope you were able to do this at least semi-automatically.

[scottmg, 2015-09-14 21:45:46]

Still a few more it looks like:
https://gist.github.com/sgraham/96f003ec4cb0f4479658

[scottmg, 2015-09-14 21:47:14]

On 2015/09/14 21:45:46, scottmg wrote:
> Still a few more it looks like:
> https://gist.github.com/sgraham/96f003ec4cb0f4479658

Er, maybe just the one.

[danakj, 2015-09-14 21:47:29]

Added util/mach/symbolic_constants_mach_test.cc

[danakj, 2015-09-14 21:47:43]

On 2015/09/14 21:45:46, scottmg wrote:
> Still a few more it looks like:
> https://gist.github.com/sgraham/96f003ec4cb0f4479658

Thanks for testing for me!!

[scottmg, 2015-09-14 21:50:47]

On 2015/09/14 21:47:43, danakj wrote:
> On 2015/09/14 21:45:46, scottmg wrote:
> > Still a few more it looks like:
> > https://gist.github.com/sgraham/96f003ec4cb0f4479658
> 
> Thanks for testing for me!!

I am trybot-extraordinaire! Builds OK in debug and release with basictypes.h
implicit_cast removed, so lgtm. Landing.

[scottmg, 2015-09-14 21:51:10]

Committed patchset #3 (id:40001) manually as
0b022d72a2a4f9b89fcd4ab6aeabc92efa93a0c2 (presubmit successful).

[danakj, 2015-09-14 21:54:10]

Hm. But not with it.

../../util/mac/launchd.mm:69:13: error: call to 'implicit_cast' is ambiguous
            implicit_cast<CFPropertyListRef>(element_ns);

In the .mm file it doesn't just use the crashpad namespace?

[danakj, 2015-09-14 21:56:29]

On 2015/09/14 21:54:10, danakj wrote:
> Hm. But not with it.
> 
> ../../util/mac/launchd.mm:69:13: error: call to 'implicit_cast' is ambiguous
>             implicit_cast<CFPropertyListRef>(element_ns);
> 
> In the .mm file it doesn't just use the crashpad namespace?

Fix? https://codereview.chromium.org/1336413003/

[danakj, 2015-09-14 21:57:56]

On 2015/09/14 21:56:29, danakj wrote:
> On 2015/09/14 21:54:10, danakj wrote:
> > Hm. But not with it.
> > 
> > ../../util/mac/launchd.mm:69:13: error: call to 'implicit_cast' is ambiguous
> >             implicit_cast<CFPropertyListRef>(element_ns);
> > 
> > In the .mm file it doesn't just use the crashpad namespace?
> 
> Fix? https://codereview.chromium.org/1336413003/

Oh, or https://codereview.chromium.org/1347483002/ should resolve this too.

[danakj, 2015-09-14 21:59:49]

On 2015/09/14 21:57:56, danakj wrote:
> On 2015/09/14 21:56:29, danakj wrote:
> > On 2015/09/14 21:54:10, danakj wrote:
> > > Hm. But not with it.
> > > 
> > > ../../util/mac/launchd.mm:69:13: error: call to 'implicit_cast' is
ambiguous
> > >             implicit_cast<CFPropertyListRef>(element_ns);
> > > 
> > > In the .mm file it doesn't just use the crashpad namespace?
> > 
> > Fix? https://codereview.chromium.org/1336413003/
> 
> Oh, or https://codereview.chromium.org/1347483002/ should resolve this too.

Though, that leaves us unable to roll either way.. we need to be able to build
with to roll this into chromium in order to remove it and build without.