Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1344673003: CrOS: Switch tryserver over to recipes, Gitiles. (Closed)

Created:
5 years, 3 months ago by dnj
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

CrOS: Switch tryserver over to recipes, Gitiles. - Switch tryserver to use recipe-based builds. - Use GitilesPoller instead of GitPoller. BUG=chromium:468178 TEST=expectations Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296702

Patch Set 1 #

Patch Set 2 : Update recipe presentation, use GitilesPoller for waterfall. #

Total comments: 2

Patch Set 3 : Update comment. #

Total comments: 13

Patch Set 4 : Update logic, unify etc path, remove "etc" variant. #

Total comments: 2

Patch Set 5 : Clean up comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -1650 lines) Patch
M masters/master.chromiumos.tryserver/chromiumos_tryserver_util.py View 2 chunks +8 lines, -8 lines 0 comments Download
M masters/master.chromiumos.tryserver/config.current.txt View 1 2 3 38 chunks +364 lines, -1372 lines 0 comments Download
M masters/master.chromiumos.tryserver/master.cfg View 1 2 3 7 chunks +25 lines, -31 lines 0 comments Download
M masters/master.chromiumos/config.current.txt View 19 chunks +19 lines, -19 lines 0 comments Download
M scripts/master/cros_try_job_git.py View 1 7 chunks +34 lines, -28 lines 0 comments Download
M scripts/master/factory/chromeos_factory.py View 7 chunks +12 lines, -16 lines 0 comments Download
M scripts/slave/recipe_modules/chromite/api.py View 1 6 chunks +7 lines, -16 lines 0 comments Download
M scripts/slave/recipe_modules/chromite/config.py View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage.json View 1 1 chunk +2 lines, -9 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.py View 1 2 3 4 6 chunks +48 lines, -16 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/basic.json View 1 3 chunks +23 lines, -4 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot_tryjob.expected/etc.json View 1 2 3 1 chunk +0 lines, -120 lines 0 comments Download
A + scripts/slave/recipes/cros/cbuildbot_tryjob.expected/unknown_config.json View 1 2 3 2 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
dnj
PTAL
5 years, 3 months ago (2015-09-15 17:02:19 UTC) #4
martiniss
lgtm for the recipes changes. Buildbot changes look ok to me, but I'm not that ...
5 years, 3 months ago (2015-09-15 17:58:58 UTC) #5
dnj
Thanks for reviewing! https://codereview.chromium.org/1344673003/diff/60001/scripts/slave/recipes/cros/cbuildbot_tryjob.py File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right): https://codereview.chromium.org/1344673003/diff/60001/scripts/slave/recipes/cros/cbuildbot_tryjob.py#newcode65 scripts/slave/recipes/cros/cbuildbot_tryjob.py:65: # If we are a tryjob, ...
5 years, 3 months ago (2015-09-15 18:33:28 UTC) #6
David James
have you tested this with some real tryjobs? cbuildbot has a --test-tryjob function which can ...
5 years, 3 months ago (2015-09-15 19:35:51 UTC) #9
phobbs
https://codereview.chromium.org/1344673003/diff/80001/scripts/master/cros_try_job_git.py File scripts/master/cros_try_job_git.py (right): https://codereview.chromium.org/1344673003/diff/80001/scripts/master/cros_try_job_git.py#newcode294 scripts/master/cros_try_job_git.py:294: raise BadJobfile( On 2015/09/15 19:35:51, David James wrote: > ...
5 years, 3 months ago (2015-09-15 21:27:49 UTC) #10
David James
https://codereview.chromium.org/1344673003/diff/80001/scripts/master/cros_try_job_git.py File scripts/master/cros_try_job_git.py (right): https://codereview.chromium.org/1344673003/diff/80001/scripts/master/cros_try_job_git.py#newcode294 scripts/master/cros_try_job_git.py:294: raise BadJobfile( On 2015/09/15 21:27:49, phobbs wrote: > On ...
5 years, 3 months ago (2015-09-15 21:34:37 UTC) #11
dnj
https://codereview.chromium.org/1344673003/diff/80001/scripts/master/cros_try_job_git.py File scripts/master/cros_try_job_git.py (right): https://codereview.chromium.org/1344673003/diff/80001/scripts/master/cros_try_job_git.py#newcode294 scripts/master/cros_try_job_git.py:294: raise BadJobfile( On 2015/09/15 21:34:37, David James wrote: > ...
5 years, 3 months ago (2015-09-15 21:55:53 UTC) #12
David James
https://codereview.chromium.org/1344673003/diff/80001/scripts/slave/recipes/cros/cbuildbot_tryjob.py File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right): https://codereview.chromium.org/1344673003/diff/80001/scripts/slave/recipes/cros/cbuildbot_tryjob.py#newcode70 scripts/slave/recipes/cros/cbuildbot_tryjob.py:70: # or external. On 2015/09/15 21:55:52, dnj wrote: > ...
5 years, 3 months ago (2015-09-15 22:02:54 UTC) #13
dnj (Google)
https://codereview.chromium.org/1344673003/diff/80001/scripts/slave/recipes/cros/cbuildbot_tryjob.py File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right): https://codereview.chromium.org/1344673003/diff/80001/scripts/slave/recipes/cros/cbuildbot_tryjob.py#newcode70 scripts/slave/recipes/cros/cbuildbot_tryjob.py:70: # or external. On 2015/09/15 22:02:54, David James wrote: ...
5 years, 3 months ago (2015-09-16 00:07:42 UTC) #15
dnj (Google)
https://codereview.chromium.org/1344673003/diff/80001/scripts/slave/recipes/cros/cbuildbot_tryjob.py File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right): https://codereview.chromium.org/1344673003/diff/80001/scripts/slave/recipes/cros/cbuildbot_tryjob.py#newcode70 scripts/slave/recipes/cros/cbuildbot_tryjob.py:70: # or external. On 2015/09/16 00:07:42, dnj (Google) wrote: ...
5 years, 3 months ago (2015-09-16 00:41:40 UTC) #16
David James
lgtm https://codereview.chromium.org/1344673003/diff/100001/scripts/slave/recipes/cros/cbuildbot_tryjob.py File scripts/slave/recipes/cros/cbuildbot_tryjob.py (right): https://codereview.chromium.org/1344673003/diff/100001/scripts/slave/recipes/cros/cbuildbot_tryjob.py#newcode70 scripts/slave/recipes/cros/cbuildbot_tryjob.py:70: # infer# which to use based on the ...
5 years, 3 months ago (2015-09-16 00:52:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344673003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344673003/120001
5 years, 3 months ago (2015-09-16 01:24:46 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 01:27:29 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296702

Powered by Google App Engine
This is Rietveld 408576698