Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1344673002: Change all view messages in RendererBlinkPlatformImpl into being render process messages. (Closed)

Created:
5 years, 3 months ago by Avi (use Gerrit)
Modified:
5 years, 3 months ago
Reviewers:
nasko, dcheng
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipc-font
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change all view messages in RendererBlinkPlatformImpl into being render process messages. BUG=304341 TEST=none Committed: https://crrev.com/a7592ff25321e29a8dba865fb2dd2942dd94cbc2 Cr-Commit-Position: refs/heads/master@{#349074}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -32 lines) Patch
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +4 lines, -4 lines 2 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/render_process_messages.h View 2 chunks +21 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +0 lines, -21 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 5 chunks +7 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344673002/1
5 years, 3 months ago (2015-09-14 21:36:06 UTC) #3
Avi (use Gerrit)
5 years, 3 months ago (2015-09-14 23:04:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/40510)
5 years, 3 months ago (2015-09-14 23:07:48 UTC) #6
nasko
LGTM
5 years, 3 months ago (2015-09-15 22:15:11 UTC) #7
dcheng
https://codereview.chromium.org/1344673002/diff/1/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/1344673002/diff/1/content/browser/renderer_host/render_message_filter.cc#newcode138 content/browser/renderer_host/render_message_filter.cc:138: IPC_MESSAGE_HANDLER(RenderProcessHostMsg_GetProcessMemorySizes, Out of curiosity, how come this gets the ...
5 years, 3 months ago (2015-09-15 22:18:22 UTC) #9
Avi (use Gerrit)
https://codereview.chromium.org/1344673002/diff/1/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/1344673002/diff/1/content/browser/renderer_host/render_message_filter.cc#newcode138 content/browser/renderer_host/render_message_filter.cc:138: IPC_MESSAGE_HANDLER(RenderProcessHostMsg_GetProcessMemorySizes, On 2015/09/15 22:18:22, dcheng wrote: > Out of ...
5 years, 3 months ago (2015-09-15 23:21:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344673002/1
5 years, 3 months ago (2015-09-16 00:39:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/63342)
5 years, 3 months ago (2015-09-16 00:47:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344673002/1
5 years, 3 months ago (2015-09-16 00:49:15 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/63350)
5 years, 3 months ago (2015-09-16 00:57:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344673002/1
5 years, 3 months ago (2015-09-16 00:58:13 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/63360)
5 years, 3 months ago (2015-09-16 01:06:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344673002/1
5 years, 3 months ago (2015-09-16 02:11:01 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 02:48:06 UTC) #25
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7592ff25321e29a8dba865fb2dd2942dd94cbc2 Cr-Commit-Position: refs/heads/master@{#349074}
5 years, 3 months ago (2015-09-16 02:48:46 UTC) #26
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:53:23 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7592ff25321e29a8dba865fb2dd2942dd94cbc2
Cr-Commit-Position: refs/heads/master@{#349074}

Powered by Google App Engine
This is Rietveld 408576698