Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344663002: remove code from SK_SUPPORT_LEGACY_NEWFROMGENERATOR, eliminates caller of deprecated SkInstallDisca… (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove code from SK_SUPPORT_LEGACY_NEWFROMGENERATOR, eliminates caller of deprecated SkInstallDiscardablePixelRef BUG=skia: Committed: https://skia.googlesource.com/skia/+/2bcab827872420762061f31200bedbd14e00b2c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/image/SkImage_Generator.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
reed1
ptal
5 years, 3 months ago (2015-09-14 20:47:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344663002/1
5 years, 3 months ago (2015-09-14 20:48:50 UTC) #4
f(malita)
lgtm
5 years, 3 months ago (2015-09-14 20:50:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344663002/1
5 years, 3 months ago (2015-09-14 20:50:48 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 20:54:42 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2bcab827872420762061f31200bedbd14e00b2c7

Powered by Google App Engine
This is Rietveld 408576698