Issue 134463006: Rebase the Dart Generator test files for 2014.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134463006: Rebase the Dart Generator test files for 2014. (Closed)

Created:
6 years, 11 months ago by dhnishi (use Chromium)

Modified:
6 years, 11 months ago

Reviewers:
dhnishi (use Chromium), benwells

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Rebase the Dart Generator test files for 2014. The test files include the year 2013 in the heading, and causes test failures when a 2014 generated file is tested. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244525

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	tools/json_schema_compiler/dart_test/comments.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/dictionaries.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/empty_namespace.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/empty_type.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/events.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/functions.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/operatable_type.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/json_schema_compiler/dart_test/tags.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dhnishi (use Chromium)

@kalman PTAL when you get a chance. I noticed the test failures when I was ...

6 years, 11 months ago (2014-01-10 21:17:22 UTC) #1

benwells

On 2014/01/10 21:18:29, kalman wrote: > reviewer --> benwells lgtm. FYI I just logged crbug.com/333726 ...

6 years, 11 months ago (2014-01-13 00:10:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/134463006/1

6 years, 11 months ago (2014-01-13 17:21:33 UTC) #4

Message was sent while issue was closed.

Change committed as 244525

Expand Messages | Collapse Messages