Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 1344613002: [MD settings] on startup use current pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index c194a7d83c3257e9efeb7c9a42203ea3be603b5f..3d45fe2411b837f65be5c16203ee8b9aa3c667fe 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -36,18 +36,48 @@ Polymer({
/** @type {!Array<string>} */
savedUrlList: {
type: Array,
- value: function() { return []; }
},
},
+ observers: [
+ 'prefsChanged_(prefs.session.startup_urls.value.*)',
+ ],
+
+ attached: function() {
+ var updateFunction = this.updateStartupPages_.bind(this);
+ cr.define('Settings', function() {
+ return {
+ updateStartupPages: updateFunction,
+ };
+ });
+ },
+
+ /** @private */
+ prefsChanged_: function(change) {
+ if (this.savedUrlList == undefined &&
+ this.get('prefs.session.startup_urls')) {
+ this.savedUrlList = this.prefs.session.startup_urls.value.slice();
+ }
+ },
+
+ /** @private */
+ updateStartupPages_: function(data) {
+ var urlArray = [];
+ for (var i = 0; i < data.length; ++i)
+ urlArray.push(data[i].url);
+ this.set('prefs.session.startup_urls.value', urlArray);
+ },
+
/** @private */
onUseCurrentPagesTap_: function() {
- // TODO(dschuyler): I'll be making a chrome.send call here.
+ chrome.send('setStartupPagesToCurrentPages');
},
/** @private */
onCancelTap_: function() {
- this.set('prefs.session.startup_urls.value', this.savedUrlList.slice());
+ if (this.savedUrlList !== undefined) {
+ this.set('prefs.session.startup_urls.value', this.savedUrlList.slice());
+ }
},
/** @private */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698