Issue 13446003: Add DriveScheduler::UploadNewFile.

Issue 13446003: Add DriveScheduler::UploadNewFile. (Closed)

Created:
7 years, 8 months ago by kinaba

Modified:
7 years, 8 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add DriveScheduler::UploadNewFile. BUG=225649 TEST=Copy a file from local to remote in the file manager of Chrome OS. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192323

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unneeded #include. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -16 lines)			Patch
M	chrome/browser/chromeos/drive/drive_scheduler.h	View		3 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler.cc	View		3 chunks	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.h	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1	3 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/drive_operations.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinaba

Please take a look. Thanks! https://codereview.chromium.org/13446003/diff/1/chrome/browser/chromeos/drive/file_system/drive_operations.cc File chrome/browser/chromeos/drive/file_system/drive_operations.cc (right): https://codereview.chromium.org/13446003/diff/1/chrome/browser/chromeos/drive/file_system/drive_operations.cc#newcode33 chrome/browser/chromeos/drive/file_system/drive_operations.cc:33: google_apis::DriveUploaderInterface* uploader, This parameter ...

7 years, 8 months ago (2013-04-02 05:55:56 UTC) #1

kinaba

On 2013/04/02 07:04:06, Zachary Kuznia wrote: > lgtm I'll land this one after the no-refactoring ...

7 years, 8 months ago (2013-04-03 02:29:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13446003/6001

7 years, 8 months ago (2013-04-04 01:59:53 UTC) #4

Message was sent while issue was closed.

Change committed as 192323

Expand Messages | Collapse Messages