src/compiler/verifier.cc - Issue 1344553003: [turbofan] Model arguments object materialization in graph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 1344553003: [turbofan] Model arguments object materialization in graph. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index 595d9be0d0d825132f0f0b828219c079f42b21c5..3d4fefd9be2b7ee0505b32a7e098accc8db329c7 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -511,6 +511,10 @@ void Verifier::Visitor::Check(Node* node) {

// Type is Object.

CheckUpperIs(node, Type::Object());

break;

+ case IrOpcode::kJSCreateArguments:

+ // Type is OtherObject.

+ CheckUpperIs(node, Type::OtherObject());

+ break;

case IrOpcode::kJSCreateClosure:

// Type is Function.

CheckUpperIs(node, Type::OtherObject());

« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »