[turbofan] Model arguments object materialization in graph.

[turbofan] Model arguments object materialization in graph.

This models the materialization of arguments objects in the prologue
within the IR graph. It will in turn allow us to optimize access to
these objects and also correctly handle them with inlining.

R=bmeurer@chromium.org,mvstanton@chromium.org
TEST=cctest/test-run-jsobjects/Arguments*

Committed: https://crrev.com/887f8760588a7f7b4e32c52872f024ceacca903f
Cr-Commit-Position: refs/heads/master@{#30735}

[Michael Starzinger, 2015-09-14 13:35:37]

Benedikt: PTAL.
Michael: FYI.

[Michael Starzinger, 2015-09-14 18:19:23]

[ +Caitlin ]

[Benedikt Meurer, 2015-09-15 04:35:50]

LGTM with nits. I love it!

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operato...
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operato...
src/compiler/js-operator.cc:732: DCHECK(start_index == 0 || type ==
CreateArgumentsParameters::REST_ARRAY);
How about DCHECK_IMPLIES(start_index != 0, type ==
CreateArgumentsParameters::REST_ARRAY) instead?

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operato...
src/compiler/js-operator.h:414: enum Type { MAPPED_ARGUMENTS,
UNMAPPED_ARGUMENTS, REST_ARRAY };
Style guide nit: use kMappedArguments, kUnmappedArguments and kRestArray
(uppercase should only be used for macros in newly written code).

[Michael Starzinger, 2015-09-15 07:39:27]

Comments addressed.

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operato...
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operato...
src/compiler/js-operator.cc:732: DCHECK(start_index == 0 || type ==
CreateArgumentsParameters::REST_ARRAY);
On 2015/09/15 04:35:50, Benedikt Meurer wrote:
> How about DCHECK_IMPLIES(start_index != 0, type ==
> CreateArgumentsParameters::REST_ARRAY) instead?

Done.

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):

https://codereview.chromium.org/1344553003/diff/20001/src/compiler/js-operato...
src/compiler/js-operator.h:414: enum Type { MAPPED_ARGUMENTS,
UNMAPPED_ARGUMENTS, REST_ARRAY };
On 2015/09/15 04:35:50, Benedikt Meurer wrote:
> Style guide nit: use kMappedArguments, kUnmappedArguments and kRestArray
> (uppercase should only be used for macros in newly written code).

Done.

[mvstanton, 2015-09-15 08:53:50]

lgtm, thx for the heads up!

[Michael Starzinger, 2015-09-15 09:05:43]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-09-15 09:05:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1344553003/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-09-15 09:05:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1344553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1344553003/40001

[commit-bot: I haz the power, 2015-09-15 09:07:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-15 09:07:44]

Patchset 3 (id:??) landed as
https://crrev.com/887f8760588a7f7b4e32c52872f024ceacca903f
Cr-Commit-Position: refs/heads/master@{#30735}