Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 134453006: Remove "using namespace" statements from headers (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, nessy, zoltan1, eae+blinkwatch, philipj_slow, gasubic, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, bemjb+rendering_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove "using namespace" statements from headers It is bad practice to have "using namespace" statements in the headers as it can change the lookup rules in unrelated implementation files. This is also against Chromium coding style: http://www.chromium.org/developers/coding-style/chromium-style-checker-errors#TOC-Using-namespace-in-a-header R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165150

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/rendering/line/LineLayoutState.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 11 months ago (2014-01-15 00:40:36 UTC) #1
esprehn
build is broken?
6 years, 11 months ago (2014-01-15 00:41:40 UTC) #2
Inactive
On 2014/01/15 00:41:40, esprehn wrote: > build is broken? I don't think so but the ...
6 years, 11 months ago (2014-01-15 00:49:10 UTC) #3
esprehn
rslgtm
6 years, 11 months ago (2014-01-15 00:49:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134453006/1
6 years, 11 months ago (2014-01-15 01:19:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
6 years, 11 months ago (2014-01-15 15:27:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134453006/200001
6 years, 11 months ago (2014-01-15 16:10:19 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 17:38:22 UTC) #8
Message was sent while issue was closed.
Change committed as 165150

Powered by Google App Engine
This is Rietveld 408576698