Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 13445005: Android: Enable content_browsertests by default. (Closed)

Created:
7 years, 8 months ago by nilesh
Modified:
7 years, 8 months ago
Reviewers:
Yaron, Isaac (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: Enable content_browsertests by default. BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194601

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : #

Patch Set 5 : Adding num_retries=1 to the run command. #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nilesh
7 years, 8 months ago (2013-04-10 17:48:04 UTC) #1
Yaron
lgtm assuming we have capacity
7 years, 8 months ago (2013-04-10 17:53:20 UTC) #2
nilesh
On 2013/04/10 17:53:20, Yaron wrote: > lgtm assuming we have capacity Isaac do you have ...
7 years, 8 months ago (2013-04-10 20:38:15 UTC) #3
Isaac (away)
I have concerns. I do not think we have capacity for this.
7 years, 8 months ago (2013-04-10 21:36:11 UTC) #4
nilesh
On 2013/04/10 21:36:11, Isaac wrote: > I have concerns. I do not think we have ...
7 years, 8 months ago (2013-04-10 22:03:36 UTC) #5
Isaac (away)
My biggest concern is that we don't not have the 'auto-reboot' script deployed yet, so ...
7 years, 8 months ago (2013-04-10 22:26:25 UTC) #6
Isaac (away)
lgtm but be sure to watch waterfall & trybots after landing.
7 years, 8 months ago (2013-04-13 02:50:37 UTC) #7
nilesh
7 years, 8 months ago (2013-04-17 15:54:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 manually as r194601 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698