Issue 13445002: Remove fake uploader from Drive tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13445002: Remove fake uploader from Drive tests. (Closed)

Created:
7 years, 8 months ago by kinaba

Modified:
7 years, 8 months ago

Reviewers:
hidehiko, satorux1

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove fake uploader from Drive tests. For DriveFileSystemTest, FakeDriveService now works well as the upload target. Thus we can use the real DriveUploader for testing. For DriveSchedulerTest, uploader is not touched at all in fact, so replacing with NULL. This is for making uploader more private inside Scheduler. BUG=225649 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191817

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -120 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_file_system_unittest.cc	View		4 chunks	+3 lines, -92 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/drive_scheduler_unittest.cc	View		3 chunks	+1 line, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinaba

Successor patch of https://codereview.chromium.org/13436003/. The change in fake_drive_service.cc is identical to the previous one. It'll ...

7 years, 8 months ago (2013-04-02 05:48:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13445002/5001

7 years, 8 months ago (2013-04-02 07:59:02 UTC) #3

Message was sent while issue was closed.

This is nice. Thanks!

Expand Messages | Collapse Messages