Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6283)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 1344443002: Implement new password separated sign in flow for chrome desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
index 5d10e9330930b85cd72c7601a352028a1cab944f..39062656ad6eeb24176bcd11c66d2ebe08ffc90f 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -49,14 +49,6 @@ void InlineLoginHandler::HandleInitializeMessage(const base::ListValue* args) {
const GURL& current_url = web_ui()->GetWebContents()->GetURL();
signin_metrics::Source source = signin::GetSourceForPromoURL(current_url);
- if (source == signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT ||
- source == signin_metrics::SOURCE_AVATAR_BUBBLE_SIGN_IN ||
- source == signin_metrics::SOURCE_REAUTH) {
- // Drop the leading slash in the path.
- params.SetString(
- "gaiaPath",
- GaiaUrls::GetInstance()->embedded_signin_url().path().substr(1));
- }
params.SetString(
"continueUrl",
@@ -96,8 +88,7 @@ void InlineLoginHandler::HandleInitializeMessage(const base::ListValue* args) {
// TODO(rogerta): this needs to be passed on to gaia somehow.
std::string read_only_email;
net::GetValueForKeyInQuery(current_url, "readOnlyEmail", &read_only_email);
- if (!read_only_email.empty())
- params.SetString("readOnlyEmail", read_only_email);
+ params.SetBoolean("readOnlyEmail", !read_only_email.empty());
SetExtraInitParams(params);

Powered by Google App Engine
This is Rietveld 408576698