Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: sync/internal_api/base_node.cc

Issue 134443004: sync: Remove some WebUI debug functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_ui.cc ('k') | sync/internal_api/public/base_node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/base_node.cc
diff --git a/sync/internal_api/base_node.cc b/sync/internal_api/base_node.cc
index 3f8f2f0aed23243df97d5e55b18c9e0b42aa29e7..2d0cdd70e629d7c43aea662690538e9bdda630ca 100644
--- a/sync/internal_api/base_node.cc
+++ b/sync/internal_api/base_node.cc
@@ -8,7 +8,6 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/values.h"
#include "sync/internal_api/public/base_transaction.h"
#include "sync/internal_api/syncapi_internal.h"
#include "sync/protocol/app_specifics.pb.h"
@@ -227,36 +226,8 @@ int BaseNode::GetPositionIndex() const {
return GetEntry()->GetPositionIndex();
}
-base::DictionaryValue* BaseNode::GetSummaryAsValue() const {
- base::DictionaryValue* node_info = new base::DictionaryValue();
- node_info->SetString("id", base::Int64ToString(GetId()));
- node_info->SetBoolean("isFolder", GetIsFolder());
- node_info->SetString("title", GetTitle());
- node_info->Set("type", ModelTypeToValue(GetModelType()));
- return node_info;
-}
-
-base::DictionaryValue* BaseNode::GetDetailsAsValue() const {
- base::DictionaryValue* node_info = GetSummaryAsValue();
- node_info->SetString(
- "modificationTime", GetTimeDebugString(GetModificationTime()));
- node_info->SetString("parentId", base::Int64ToString(GetParentId()));
- // Specifics are already in the Entry value, so no need to duplicate
- // it here.
- node_info->SetString("externalId", base::Int64ToString(GetExternalId()));
- if (GetEntry()->ShouldMaintainPosition() &&
- !GetEntry()->GetIsDel()) {
- node_info->SetString("successorId", base::Int64ToString(GetSuccessorId()));
- node_info->SetString(
- "predecessorId", base::Int64ToString(GetPredecessorId()));
- }
- if (GetEntry()->GetIsDir()) {
- node_info->SetString(
- "firstChildId", base::Int64ToString(GetFirstChildId()));
- }
- node_info->Set(
- "entry", GetEntry()->ToValue(GetTransaction()->GetCryptographer()));
- return node_info;
+base::DictionaryValue* BaseNode::ToValue() const {
+ return GetEntry()->ToValue(GetTransaction()->GetCryptographer());
}
int64 BaseNode::GetExternalId() const {
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_ui.cc ('k') | sync/internal_api/public/base_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698