Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: Source/core/fetch/RawResource.h

Issue 134443002: Update fetch / loader classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No OVERRIDE / FINAL in web Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/MockImageResourceClient.h ('k') | Source/core/fetch/ResourceFetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/RawResource.h
diff --git a/Source/core/fetch/RawResource.h b/Source/core/fetch/RawResource.h
index 57ce6fb2195eb16f3d4e221757037680384bd6e4..327fd218b250f79d5b2cc8353b60c484017518fe 100644
--- a/Source/core/fetch/RawResource.h
+++ b/Source/core/fetch/RawResource.h
@@ -30,7 +30,7 @@ namespace WebCore {
class RawResourceCallback;
class RawResourceClient;
-class RawResource : public Resource {
+class RawResource FINAL : public Resource {
public:
typedef RawResourceClient ClientType;
@@ -39,21 +39,21 @@ public:
// FIXME: AssociatedURLLoader shouldn't be a DocumentThreadableLoader and therefore shouldn't
// use RawResource. However, it is, and it needs to be able to defer loading.
// This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader.
- virtual void setDefersLoading(bool);
+ void setDefersLoading(bool);
- virtual bool canReuse(const ResourceRequest&) const;
+ virtual bool canReuse(const ResourceRequest&) const OVERRIDE;
private:
- virtual void didAddClient(ResourceClient*);
+ virtual void didAddClient(ResourceClient*) OVERRIDE;
virtual void appendData(const char*, int) OVERRIDE;
- virtual bool shouldIgnoreHTTPStatusCodeErrors() const { return true; }
+ virtual bool shouldIgnoreHTTPStatusCodeErrors() const OVERRIDE { return true; }
- virtual void willSendRequest(ResourceRequest&, const ResourceResponse&);
- virtual void updateRequest(const ResourceRequest&);
- virtual void responseReceived(const ResourceResponse&);
- virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
- virtual void didDownloadData(int);
+ virtual void willSendRequest(ResourceRequest&, const ResourceResponse&) OVERRIDE;
+ virtual void updateRequest(const ResourceRequest&) OVERRIDE;
+ virtual void responseReceived(const ResourceResponse&) OVERRIDE;
+ virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
+ virtual void didDownloadData(int) OVERRIDE;
struct RedirectPair {
public:
@@ -87,7 +87,7 @@ class RawResourceClient : public ResourceClient {
public:
virtual ~RawResourceClient() { }
static ResourceClientType expectedType() { return RawResourceType; }
- virtual ResourceClientType resourceClientType() const { return expectedType(); }
+ virtual ResourceClientType resourceClientType() const OVERRIDE FINAL { return expectedType(); }
virtual void dataSent(Resource*, unsigned long long /* bytesSent */, unsigned long long /* totalBytesToBeSent */) { }
virtual void responseReceived(Resource*, const ResourceResponse&) { }
« no previous file with comments | « Source/core/fetch/MockImageResourceClient.h ('k') | Source/core/fetch/ResourceFetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698