Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/core/loader/EmptyClients.h

Issue 134443002: Update fetch / loader classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No OVERRIDE / FINAL in web Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 virtual void setTouchAction(TouchAction touchAction) OVERRIDE { }; 165 virtual void setTouchAction(TouchAction touchAction) OVERRIDE { };
166 166
167 virtual void numWheelEventHandlersChanged(unsigned) OVERRIDE { } 167 virtual void numWheelEventHandlersChanged(unsigned) OVERRIDE { }
168 168
169 virtual bool shouldRubberBandInDirection(WebCore::ScrollDirection) const OVE RRIDE { return false; } 169 virtual bool shouldRubberBandInDirection(WebCore::ScrollDirection) const OVE RRIDE { return false; }
170 170
171 virtual bool isEmptyChromeClient() const OVERRIDE { return true; } 171 virtual bool isEmptyChromeClient() const OVERRIDE { return true; }
172 172
173 virtual void didAssociateFormControls(const Vector<RefPtr<Element> >&) OVERR IDE { } 173 virtual void didAssociateFormControls(const Vector<RefPtr<Element> >&) OVERR IDE { }
174 174
175 virtual void popupOpened(PopupContainer* popupContainer, const IntRect& boun ds, 175 virtual void popupOpened(PopupContainer* popupContainer, const IntRect& boun ds, bool handleExternal) OVERRIDE { }
176 bool handleExternal) { }
177 virtual void popupClosed(PopupContainer* popupContainer) OVERRIDE { } 176 virtual void popupClosed(PopupContainer* popupContainer) OVERRIDE { }
178 177
179 virtual void annotatedRegionsChanged() OVERRIDE { } 178 virtual void annotatedRegionsChanged() OVERRIDE { }
180 virtual bool paintCustomOverhangArea(GraphicsContext*, const IntRect&, const IntRect&, const IntRect&) OVERRIDE { return false; } 179 virtual bool paintCustomOverhangArea(GraphicsContext*, const IntRect&, const IntRect&, const IntRect&) OVERRIDE { return false; }
181 virtual String acceptLanguages() OVERRIDE; 180 virtual String acceptLanguages() OVERRIDE;
182 }; 181 };
183 182
184 class EmptyFrameLoaderClient : public FrameLoaderClient { 183 class EmptyFrameLoaderClient FINAL : public FrameLoaderClient {
185 WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); WTF_MAKE_FAST_ALLOCATED; 184 WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); WTF_MAKE_FAST_ALLOCATED;
186 public: 185 public:
187 EmptyFrameLoaderClient() { } 186 EmptyFrameLoaderClient() { }
188 virtual ~EmptyFrameLoaderClient() { } 187 virtual ~EmptyFrameLoaderClient() { }
189 188
190 virtual bool hasWebView() const OVERRIDE { return true; } // mainly for asse rtions 189 virtual bool hasWebView() const OVERRIDE { return true; } // mainly for asse rtions
191 190
192 virtual void detachedFromParent() OVERRIDE { } 191 virtual void detachedFromParent() OVERRIDE { }
193 192
194 virtual void dispatchWillSendRequest(DocumentLoader*, unsigned long, Resourc eRequest&, const ResourceResponse&) OVERRIDE { } 193 virtual void dispatchWillSendRequest(DocumentLoader*, unsigned long, Resourc eRequest&, const ResourceResponse&) OVERRIDE { }
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 239
241 virtual ObjectContentType objectContentType(const KURL&, const String&, bool ) OVERRIDE { return ObjectContentType(); } 240 virtual ObjectContentType objectContentType(const KURL&, const String&, bool ) OVERRIDE { return ObjectContentType(); }
242 241
243 virtual void dispatchDidClearWindowObjectInWorld(DOMWrapperWorld*) OVERRIDE { } 242 virtual void dispatchDidClearWindowObjectInWorld(DOMWrapperWorld*) OVERRIDE { }
244 virtual void documentElementAvailable() OVERRIDE { } 243 virtual void documentElementAvailable() OVERRIDE { }
245 244
246 virtual void didCreateScriptContext(v8::Handle<v8::Context>, int extensionGr oup, int worldId) OVERRIDE { } 245 virtual void didCreateScriptContext(v8::Handle<v8::Context>, int extensionGr oup, int worldId) OVERRIDE { }
247 virtual void willReleaseScriptContext(v8::Handle<v8::Context>, int worldId) OVERRIDE { } 246 virtual void willReleaseScriptContext(v8::Handle<v8::Context>, int worldId) OVERRIDE { }
248 virtual bool allowScriptExtension(const String& extensionName, int extension Group, int worldId) OVERRIDE { return false; } 247 virtual bool allowScriptExtension(const String& extensionName, int extension Group, int worldId) OVERRIDE { return false; }
249 248
250 virtual blink::WebCookieJar* cookieJar() const { return 0; } 249 virtual blink::WebCookieJar* cookieJar() const OVERRIDE { return 0; }
251 250
252 virtual void didRequestAutocomplete(PassRefPtr<FormState>) OVERRIDE; 251 virtual void didRequestAutocomplete(PassRefPtr<FormState>) OVERRIDE;
253 virtual PassOwnPtr<blink::WebServiceWorkerProvider> createServiceWorkerProvi der(PassOwnPtr<blink::WebServiceWorkerProviderClient>) OVERRIDE; 252 virtual PassOwnPtr<blink::WebServiceWorkerProvider> createServiceWorkerProvi der(PassOwnPtr<blink::WebServiceWorkerProviderClient>) OVERRIDE;
254 }; 253 };
255 254
256 class EmptyTextCheckerClient : public TextCheckerClient { 255 class EmptyTextCheckerClient FINAL : public TextCheckerClient {
257 public: 256 public:
258 virtual bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const OVERRIDE { return true; } 257 virtual bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const OVERRIDE { return true; }
259 virtual void checkSpellingOfString(const String&, int*, int*) OVERRIDE { } 258 virtual void checkSpellingOfString(const String&, int*, int*) OVERRIDE { }
260 virtual String getAutoCorrectSuggestionForMisspelledWord(const String&) OVER RIDE { return String(); } 259 virtual String getAutoCorrectSuggestionForMisspelledWord(const String&) OVER RIDE { return String(); }
261 virtual void checkGrammarOfString(const String&, Vector<GrammarDetail>&, int *, int*) OVERRIDE { } 260 virtual void checkGrammarOfString(const String&, Vector<GrammarDetail>&, int *, int*) OVERRIDE { }
262 virtual void requestCheckingOfString(PassRefPtr<TextCheckingRequest>) OVERRI DE; 261 virtual void requestCheckingOfString(PassRefPtr<TextCheckingRequest>) OVERRI DE;
263 }; 262 };
264 263
265 class EmptySpellCheckerClient : public SpellCheckerClient { 264 class EmptySpellCheckerClient FINAL : public SpellCheckerClient {
266 WTF_MAKE_NONCOPYABLE(EmptySpellCheckerClient); WTF_MAKE_FAST_ALLOCATED; 265 WTF_MAKE_NONCOPYABLE(EmptySpellCheckerClient); WTF_MAKE_FAST_ALLOCATED;
267 public: 266 public:
268 EmptySpellCheckerClient() { } 267 EmptySpellCheckerClient() { }
269 virtual ~EmptySpellCheckerClient() { } 268 virtual ~EmptySpellCheckerClient() { }
270 269
271 virtual bool isContinuousSpellCheckingEnabled() OVERRIDE { return false; } 270 virtual bool isContinuousSpellCheckingEnabled() OVERRIDE { return false; }
272 virtual void toggleContinuousSpellChecking() OVERRIDE { } 271 virtual void toggleContinuousSpellChecking() OVERRIDE { }
273 virtual bool isGrammarCheckingEnabled() OVERRIDE { return false; } 272 virtual bool isGrammarCheckingEnabled() OVERRIDE { return false; }
274 273
275 TextCheckerClient& textChecker() { return m_textCheckerClient; } 274 virtual TextCheckerClient& textChecker() OVERRIDE { return m_textCheckerClie nt; }
276 275
277 virtual void updateSpellingUIWithMisspelledWord(const String&) OVERRIDE { } 276 virtual void updateSpellingUIWithMisspelledWord(const String&) OVERRIDE { }
278 virtual void showSpellingUI(bool) OVERRIDE { } 277 virtual void showSpellingUI(bool) OVERRIDE { }
279 virtual bool spellingUIIsShowing() OVERRIDE { return false; } 278 virtual bool spellingUIIsShowing() OVERRIDE { return false; }
280 279
281 private: 280 private:
282 EmptyTextCheckerClient m_textCheckerClient; 281 EmptyTextCheckerClient m_textCheckerClient;
283 }; 282 };
284 283
285 class EmptyEditorClient : public EditorClient { 284 class EmptyEditorClient FINAL : public EditorClient {
286 WTF_MAKE_NONCOPYABLE(EmptyEditorClient); WTF_MAKE_FAST_ALLOCATED; 285 WTF_MAKE_NONCOPYABLE(EmptyEditorClient); WTF_MAKE_FAST_ALLOCATED;
287 public: 286 public:
288 EmptyEditorClient() { } 287 EmptyEditorClient() { }
289 virtual ~EmptyEditorClient() { } 288 virtual ~EmptyEditorClient() { }
290 289
291 virtual void respondToChangedContents() OVERRIDE { } 290 virtual void respondToChangedContents() OVERRIDE { }
292 virtual void respondToChangedSelection(SelectionType) OVERRIDE { } 291 virtual void respondToChangedSelection(SelectionType) OVERRIDE { }
293 292
294 virtual bool canCopyCut(Frame*, bool defaultValue) const OVERRIDE { return d efaultValue; } 293 virtual bool canCopyCut(Frame*, bool defaultValue) const OVERRIDE { return d efaultValue; }
295 virtual bool canPaste(Frame*, bool defaultValue) const OVERRIDE { return def aultValue; } 294 virtual bool canPaste(Frame*, bool defaultValue) const OVERRIDE { return def aultValue; }
296 295
297 virtual void didExecuteCommand(String) OVERRIDE { } 296 virtual void didExecuteCommand(String) OVERRIDE { }
298 virtual bool handleKeyboardEvent() OVERRIDE { return false; } 297 virtual bool handleKeyboardEvent() OVERRIDE { return false; }
299 }; 298 };
300 299
301 class EmptyContextMenuClient : public ContextMenuClient { 300 class EmptyContextMenuClient FINAL : public ContextMenuClient {
302 WTF_MAKE_NONCOPYABLE(EmptyContextMenuClient); WTF_MAKE_FAST_ALLOCATED; 301 WTF_MAKE_NONCOPYABLE(EmptyContextMenuClient); WTF_MAKE_FAST_ALLOCATED;
303 public: 302 public:
304 EmptyContextMenuClient() { } 303 EmptyContextMenuClient() { }
305 virtual ~EmptyContextMenuClient() { } 304 virtual ~EmptyContextMenuClient() { }
306 virtual void showContextMenu(const ContextMenu*) OVERRIDE { } 305 virtual void showContextMenu(const ContextMenu*) OVERRIDE { }
307 virtual void clearContextMenu() OVERRIDE { } 306 virtual void clearContextMenu() OVERRIDE { }
308 }; 307 };
309 308
310 class EmptyDragClient : public DragClient { 309 class EmptyDragClient FINAL : public DragClient {
311 WTF_MAKE_NONCOPYABLE(EmptyDragClient); WTF_MAKE_FAST_ALLOCATED; 310 WTF_MAKE_NONCOPYABLE(EmptyDragClient); WTF_MAKE_FAST_ALLOCATED;
312 public: 311 public:
313 EmptyDragClient() { } 312 EmptyDragClient() { }
314 virtual ~EmptyDragClient() {} 313 virtual ~EmptyDragClient() {}
315 virtual DragDestinationAction actionMaskForDrag(DragData*) OVERRIDE { return DragDestinationActionNone; } 314 virtual DragDestinationAction actionMaskForDrag(DragData*) OVERRIDE { return DragDestinationActionNone; }
316 virtual void startDrag(DragImage*, const IntPoint&, const IntPoint&, Clipboa rd*, Frame*, bool) OVERRIDE { } 315 virtual void startDrag(DragImage*, const IntPoint&, const IntPoint&, Clipboa rd*, Frame*, bool) OVERRIDE { }
317 }; 316 };
318 317
319 class EmptyInspectorClient : public InspectorClient { 318 class EmptyInspectorClient FINAL : public InspectorClient {
320 WTF_MAKE_NONCOPYABLE(EmptyInspectorClient); WTF_MAKE_FAST_ALLOCATED; 319 WTF_MAKE_NONCOPYABLE(EmptyInspectorClient); WTF_MAKE_FAST_ALLOCATED;
321 public: 320 public:
322 EmptyInspectorClient() { } 321 EmptyInspectorClient() { }
323 virtual ~EmptyInspectorClient() { } 322 virtual ~EmptyInspectorClient() { }
324 323
325 virtual void highlight() OVERRIDE { } 324 virtual void highlight() OVERRIDE { }
326 virtual void hideHighlight() OVERRIDE { } 325 virtual void hideHighlight() OVERRIDE { }
327 }; 326 };
328 327
329 class EmptyBackForwardClient : public BackForwardClient { 328 class EmptyBackForwardClient FINAL : public BackForwardClient {
330 public: 329 public:
331 virtual int backListCount() OVERRIDE { return 0; } 330 virtual int backListCount() OVERRIDE { return 0; }
332 virtual int forwardListCount() OVERRIDE { return 0; } 331 virtual int forwardListCount() OVERRIDE { return 0; }
333 virtual int backForwardListCount() OVERRIDE { return 0; } 332 virtual int backForwardListCount() OVERRIDE { return 0; }
334 }; 333 };
335 334
336 void fillWithEmptyClients(Page::PageClients&); 335 void fillWithEmptyClients(Page::PageClients&);
337 336
338 } 337 }
339 338
340 #endif // EmptyClients_h 339 #endif // EmptyClients_h
OLDNEW
« no previous file with comments | « Source/core/loader/DocumentThreadableLoaderClient.h ('k') | Source/core/loader/FrameFetchContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698