Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344393002: Add H422ToARGB armv7 neon version. (Closed)

Created:
5 years, 3 months ago by zhongwei.yao
Modified:
5 years, 3 months ago
Reviewers:
fbarchard, fbarchard1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M include/libyuv/row.h View 1 3 chunks +12 lines, -1 line 0 comments Download
M source/row_any.cc View 1 chunk +1 line, -0 lines 0 comments Download
M source/row_common.cc View 2 chunks +2 lines, -1 line 0 comments Download
M source/row_neon.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zhongwei.yao
5 years, 3 months ago (2015-09-16 08:53:58 UTC) #1
fbarchard
lgtm
5 years, 3 months ago (2015-09-16 17:45:18 UTC) #3
fbarchard
https://codereview.chromium.org/1344393002/diff/1/include/libyuv/row.h File include/libyuv/row.h (right): https://codereview.chromium.org/1344393002/diff/1/include/libyuv/row.h#newcode306 include/libyuv/row.h:306: // TODO(fbarchard): Implement NEON version This TODO should read ...
5 years, 3 months ago (2015-09-16 22:29:15 UTC) #4
zhongwei.yao
https://codereview.chromium.org/1344393002/diff/1/include/libyuv/row.h File include/libyuv/row.h (right): https://codereview.chromium.org/1344393002/diff/1/include/libyuv/row.h#newcode306 include/libyuv/row.h:306: // TODO(fbarchard): Implement NEON version On 2015/09/16 22:29:15, fbarchard ...
5 years, 3 months ago (2015-09-17 02:08:32 UTC) #5
fbarchard1
5 years, 3 months ago (2015-09-17 17:38:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6a6b67e7a94b44909567733799e094d60a5b33b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698