Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1344383002: X87: Reland VectorICs: ia32 store ics need a virtual register. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland VectorICs: ia32 store ics need a virtual register. port 1e00bb57a2969e3e428a1d552116752a95c06022 (r30737). original commit message: (reason for revert/reland: patch incorrectly left --vector-stores flag on, helpfully revealing some gcstress issues to look at, but they don't need to block this CL). Some pretty hacky code was used to carry out the tail-call handler dispatch on ia32 vector stores due to a lack of free registers. It really tanks performance. A better approach is to use a virtual register on the isolate. BUG= Committed: https://crrev.com/ecc6e6c52c75a388fa9de13377365b9ce4a7d29a Cr-Commit-Position: refs/heads/master@{#30781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M src/ic/x87/stub-cache-x87.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 8 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-16 09:00:48 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-17 00:34:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344383002/1
5 years, 3 months ago (2015-09-17 00:34:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 01:25:26 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 01:25:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecc6e6c52c75a388fa9de13377365b9ce4a7d29a
Cr-Commit-Position: refs/heads/master@{#30781}

Powered by Google App Engine
This is Rietveld 408576698