Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1344373002:
cc: Fix PictureLayerImplPerfTest DCHECK failures. (Closed)
DescriptionUsing pending tree was breaking the dchecks, use active tree instead.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/a543d12194462ac37a25d150dcbb0077ccd72b73
Cr-Commit-Position: refs/heads/master@{#351265}
Patch Set 1 #Patch Set 2 : use active tree for raster/evict tests. #Patch Set 3 : rebase to ToT. #Messages
Total messages: 22 (8 generated)
sohan.jyoti@samsung.com changed reviewers: + vmpstr@chromium.org
The CQ bit was checked by sohan.jyoti@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344373002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Hi this looks good. Can you please verify that the perf runs before and after your patch are similar? We don't want to accidentally start measuring the wrong thing.
On 2015/09/23 17:40:37, vmpstr wrote: > Hi this looks good. Can you please verify that the perf runs before and after > your patch are similar? We don't want to accidentally start measuring the wrong > thing. Looks ok to me. we test less though in pending tree, because the non ideal scales would anyways be removed. Before Patch ================== [----------] 4 tests from PictureLayerImplPerfTest [ RUN ] PictureLayerImplPerfTest.TilingSetRasterQueueConstructAndIterate *RESULT tiling_set_raster_queue_construct_and_iterate: 32_100x100= 75501.0390625 runs/s *RESULT tiling_set_raster_queue_construct_and_iterate: 32_500x500= 78060.5078125 runs/s *RESULT tiling_set_raster_queue_construct_and_iterate: 64_100x100= 44543.73046875 runs/s *RESULT tiling_set_raster_queue_construct_and_iterate: 64_500x500= 43538.43359375 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetRasterQueueConstructAndIterate (8026 ms) [ RUN ] PictureLayerImplPerfTest.TilingSetRasterQueueConstruct *RESULT tiling_set_raster_queue_construct: 0_0_100x100= 970232.5625 runs/s *RESULT tiling_set_raster_queue_construct: 5000_0_100x100= 912908.1875 runs/s *RESULT tiling_set_raster_queue_construct: 9999_0_100x100= 915621.3125 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetRasterQueueConstruct (6025 ms) [ RUN ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstructAndIterate *RESULT tiling_set_eviction_queue_construct_and_iterate: 32_100x100= 93749.015625 runs/s *RESULT tiling_set_eviction_queue_construct_and_iterate: 32_500x500= 46962.98046875 runs/s *RESULT tiling_set_eviction_queue_construct_and_iterate: 64_100x100= 49088.84765625 runs/s *RESULT tiling_set_eviction_queue_construct_and_iterate: 64_500x500= 32332.07421875 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstructAndIterate (8085 ms) [ RUN ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstruct *RESULT tiling_set_eviction_queue_construct: 0_0_100x100= 859919.5625 runs/s *RESULT tiling_set_eviction_queue_construct: 5000_0_100x100= 256182.5625 runs/s *RESULT tiling_set_eviction_queue_construct: 9999_0_100x100= 45226.3828125 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstruct (6084 ms) [----------] 4 tests from PictureLayerImplPerfTest (28220 ms total) After patch ============= [----------] 4 tests from PictureLayerImplPerfTest [ RUN ] PictureLayerImplPerfTest.TilingSetRasterQueueConstructAndIterate *RESULT tiling_set_raster_queue_construct_and_iterate: 32_100x100= 75583.9453125 runs/s *RESULT tiling_set_raster_queue_construct_and_iterate: 32_500x500= 76042.9453125 runs/s *RESULT tiling_set_raster_queue_construct_and_iterate: 64_100x100= 43877.5859375 runs/s *RESULT tiling_set_raster_queue_construct_and_iterate: 64_500x500= 44007.51171875 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetRasterQueueConstructAndIterate (8026 ms) [ RUN ] PictureLayerImplPerfTest.TilingSetRasterQueueConstruct *RESULT tiling_set_raster_queue_construct: 0_0_100x100= 948228.5625 runs/s *RESULT tiling_set_raster_queue_construct: 5000_0_100x100= 908127.75 runs/s *RESULT tiling_set_raster_queue_construct: 9999_0_100x100= 910260 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetRasterQueueConstruct (6023 ms) [ RUN ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstructAndIterate *RESULT tiling_set_eviction_queue_construct_and_iterate: 32_100x100= 90800.9609375 runs/s *RESULT tiling_set_eviction_queue_construct_and_iterate: 32_500x500= 90194.0546875 runs/s *RESULT tiling_set_eviction_queue_construct_and_iterate: 64_100x100= 47843.18359375 runs/s *RESULT tiling_set_eviction_queue_construct_and_iterate: 64_500x500= 47889.6875 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstructAndIterate (8082 ms) [ RUN ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstruct *RESULT tiling_set_eviction_queue_construct: 0_0_100x100= 895263.1875 runs/s *RESULT tiling_set_eviction_queue_construct: 5000_0_100x100= 302447.59375 runs/s *RESULT tiling_set_eviction_queue_construct: 9999_0_100x100= 44214.00390625 runs/s [ OK ] PictureLayerImplPerfTest.TilingSetEvictionQueueConstruct (6084 ms) [----------] 4 tests from PictureLayerImplPerfTest (28215 ms total)
lgtm
The CQ bit was checked by sohan.jyoti@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344373002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sohan.jyoti@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344373002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2015/09/29 06:17:58, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Vlad, had to re-base this. Would you please take a look, before we cq it.
still lgtm
The CQ bit was checked by sohan.jyoti@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344373002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a543d12194462ac37a25d150dcbb0077ccd72b73 Cr-Commit-Position: refs/heads/master@{#351265} |
