Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1344283004: Update handling of negative radius for feMorphology (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), fs, gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update handling of negative radius for feMorphology Spec[1] states: "A negative or zero value disables the effect of the given filter primitive (i.e., the result is the filter input image)." So change FEMorphology to clamp radii to non-negative and stop treating as an error in SVGFEMorphologyElement::build. [1] https://drafts.fxtf.org/filters/#element-attrdef-femorphology-radius BUG=533457 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
A LayoutTests/svg/filters/feMorphology-negative-radius.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/svg/filters/feMorphology-negative-radius-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M Source/platform/graphics/filters/FEMorphology.cpp View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 3 months ago (2015-09-22 19:46:44 UTC) #2
pdr.
lgtm
5 years, 3 months ago (2015-09-22 19:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344283004/1
5 years, 3 months ago (2015-09-22 19:53:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202644
5 years, 3 months ago (2015-09-22 21:05:41 UTC) #6
Stephen White
5 years, 3 months ago (2015-09-23 13:57:29 UTC) #7
Message was sent while issue was closed.
vacation-delayed LGTM

Powered by Google App Engine
This is Rietveld 408576698