Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1344263002: ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: gbm: Default use_system_minigbm=1 to mitigate build breaks The chrome-sdk needs to update with the flag to avoid breakage. This CL can be reverted when the chrome-sdk updates with the new use_system_minigbm setting in GYP_DEFINES. TBR=dnicoara (build break) NOTRY=true Committed: https://crrev.com/0e8f0106e7e01cee911dd2b34c263c01788e7186 Cr-Commit-Position: refs/heads/master@{#349041}

Patch Set 1 #

Patch Set 2 : also disable gbm #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/minigbm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/minigbm/minigbm.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/ozone.gni View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
spang
5 years, 3 months ago (2015-09-15 23:51:09 UTC) #2
spang
Committed patchset #3 (id:40001) to pending queue manually as b072be481cc35829d932c16c462b8ede73ddf68a.
5 years, 3 months ago (2015-09-16 00:15:04 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0e8f0106e7e01cee911dd2b34c263c01788e7186 Cr-Commit-Position: refs/heads/master@{#349041}
5 years, 3 months ago (2015-09-16 00:15:55 UTC) #9
dnicoara
lgtm
5 years, 3 months ago (2015-09-16 00:38:14 UTC) #10
spang
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1357433003/ by spang@chromium.org. ...
5 years, 3 months ago (2015-09-17 16:29:38 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:51:31 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e8f0106e7e01cee911dd2b34c263c01788e7186
Cr-Commit-Position: refs/heads/master@{#349041}

Powered by Google App Engine
This is Rietveld 408576698