Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1344223002: Revert of Overhaul Mandoline event transport code (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
Reviewers:
rjkroege, sadrul, jam, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Overhaul Mandoline event transport code (patchset #5 id:80001 of https://codereview.chromium.org/1313353010/ ) Reason for revert: Broke GN build: ERROR at //components/html_viewer/input_events_unittest.cc:10:11: Can't include this header from here. #include "ui/events/event.h" ^---------------- The target: //components/html_viewer:html_viewer_unittests is including a file from the target: //ui/events:events It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //components/html_viewer:html_viewer_unittests --> //components/html_viewer:lib --[private]--> //ui/events:events https://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32020/steps/gn_check/logs/stdio Original issue's description: > Overhaul Mandoline event transport code > > In the course of its development, Mandoline's event code has diverged away > from event payloads that are a good fit with the current state of blink's > input handling logic. This CL begins a process of updating the event code > with an extended wheel interface capable of supporting the standards track > wheel event and revised pointer events that will be extended in a future > CL with support for the pointer events specification. > > BUG=524828 > > Committed: https://crrev.com/895c6c35457b7fe13da31e862cd50eb537d5e7e6 > Cr-Commit-Position: refs/heads/master@{#349015} TBR=sadrul@chromium.org,sky@chromium.org,jam@chromium.org,rjkroege@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524828 Committed: https://crrev.com/8c809cd1d00c4a46cfd09194a41e45a9bd603621 Cr-Commit-Position: refs/heads/master@{#349024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -369 lines) Patch
M components/html_viewer/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/blink_input_events_type_converters.cc View 3 chunks +29 lines, -51 lines 0 comments Download
M components/html_viewer/html_frame.cc View 1 chunk +4 lines, -6 lines 0 comments Download
D components/html_viewer/input_events_unittest.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M components/html_viewer/touch_handler.cc View 1 chunk +8 lines, -24 lines 0 comments Download
M components/mus/display_manager.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M components/mus/event_dispatcher.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M components/mus/gesture_manager.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/mus/gesture_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 6 chunks +56 lines, -104 lines 0 comments Download
M ui/mojo/events/input_event_constants.mojom View 2 chunks +1 line, -10 lines 0 comments Download
M ui/mojo/events/input_events.mojom View 2 chunks +12 lines, -51 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Created Revert of Overhaul Mandoline event transport code
5 years, 3 months ago (2015-09-15 23:16:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344223002/1
5 years, 3 months ago (2015-09-15 23:17:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 23:19:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8c809cd1d00c4a46cfd09194a41e45a9bd603621 Cr-Commit-Position: refs/heads/master@{#349024}
5 years, 3 months ago (2015-09-15 23:19:53 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:50:53 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c809cd1d00c4a46cfd09194a41e45a9bd603621
Cr-Commit-Position: refs/heads/master@{#349024}

Powered by Google App Engine
This is Rietveld 408576698