DescriptionRevert of Overhaul Mandoline event transport code (patchset #5 id:80001 of https://codereview.chromium.org/1313353010/ )
Reason for revert:
Broke GN build:
ERROR at //components/html_viewer/input_events_unittest.cc:10:11: Can't include this header from here.
#include "ui/events/event.h"
^----------------
The target:
//components/html_viewer:html_viewer_unittests
is including a file from the target:
//ui/events:events
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
//components/html_viewer:html_viewer_unittests -->
//components/html_viewer:lib --[private]-->
//ui/events:events
https://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32020/steps/gn_check/logs/stdio
Original issue's description:
> Overhaul Mandoline event transport code
>
> In the course of its development, Mandoline's event code has diverged away
> from event payloads that are a good fit with the current state of blink's
> input handling logic. This CL begins a process of updating the event code
> with an extended wheel interface capable of supporting the standards track
> wheel event and revised pointer events that will be extended in a future
> CL with support for the pointer events specification.
>
> BUG=524828
>
> Committed: https://crrev.com/895c6c35457b7fe13da31e862cd50eb537d5e7e6
> Cr-Commit-Position: refs/heads/master@{#349015}
TBR=sadrul@chromium.org,sky@chromium.org,jam@chromium.org,rjkroege@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=524828
Committed: https://crrev.com/8c809cd1d00c4a46cfd09194a41e45a9bd603621
Cr-Commit-Position: refs/heads/master@{#349024}
Patch Set 1 #Messages
Total messages: 5 (0 generated)
|