runtime/vm/assembler_mips.h - Issue 1344153002: ARM & MIPS: Try to use the object pool before trying to embed a pointer, like ARM64 and X64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_mips.h

Issue 1344153002: ARM & MIPS: Try to use the object pool before trying to embed a pointer, like ARM64 and X64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_mips.h

diff --git a/runtime/vm/assembler_mips.h b/runtime/vm/assembler_mips.h

index 2ae9456faf16196d1ac873ef13399822eee9b21e..f3aaed52ea3a942db5018788bddc8809208723db 100644

--- a/runtime/vm/assembler_mips.h

+++ b/runtime/vm/assembler_mips.h

@@ -1518,6 +1518,7 @@ class Assembler : public ValueObject {

void EnterCallRuntimeFrame(intptr_t frame_space);

void LeaveCallRuntimeFrame();

+ bool CanLoadFromObjectPool(const Object& object) const;

void LoadWordFromPoolOffset(Register rd, int32_t offset);

void LoadObject(Register rd, const Object& object);

void LoadUniqueObject(Register rd, const Object& object);

« runtime/vm/assembler_arm.cc ('K') | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_mips.cc » ('j') | runtime/vm/assembler_mips.cc » ('J')