Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 134403003: chromium-status: fix interpretation of week days when localizing timestamps (Closed)

Created:
6 years, 11 months ago by vapier
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

chromium-status: fix interpretation of week days when localizing timestamps The short timestamps the server outputs does not include a year: Fri, 10 Jan 18:11 this means when we try to localize things, javascript picks a year for us (2001) and uses that to figure out the new day of the week. For now, assume all short timestamps represent this year. It'll be right the majority of the time (only when showing Dec dates during Jan will it be slightly off). BUG=chromium:314501 TEST=ran an appengine and checked the day of the week to make sure it was correct Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M static/js/main/main.js View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vapier
6 years, 11 months ago (2014-01-13 22:04:57 UTC) #1
Vadim Sh.
lgtm as a quick fix Alternative solution would be to embed raw unix timestamp as ...
6 years, 11 months ago (2014-01-13 22:49:42 UTC) #2
vapier
i thought about the hidden data embedding, but seemed like it'd take a lot more ...
6 years, 11 months ago (2014-01-13 22:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/134403003/1
6 years, 11 months ago (2014-01-13 22:52:59 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 22:53:03 UTC) #5
Message was sent while issue was closed.
Change committed as 244603

Powered by Google App Engine
This is Rietveld 408576698