Issue 1343933003: Don't hard-code usage string in mojo_run.

Issue 1343933003: Don't hard-code usage string in mojo_run. (Closed)

Created:
5 years, 3 months ago by ppi

Modified:
5 years, 3 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Don't hard-code usage string in mojo_run. This easily gets out of date - e.g. it contains a '--sky' flag that went away when the repos split and does not contain most of the actual script arguments. Instead, describe notable shell arguments in the description string and allow argparse to generate USAGE. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fa3d04fd42c795a12aeaf07910b03e5708813e8b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -19 lines)			Patch
	M	mojo/devtools/common/mojo_run	View	1	2 chunks	+15 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

qsr

lgtm https://codereview.chromium.org/1343933003/diff/1/mojo/devtools/common/mojo_run File mojo/devtools/common/mojo_run (right): https://codereview.chromium.org/1343933003/diff/1/mojo/devtools/common/mojo_run#newcode20 mojo/devtools/common/mojo_run:20: "--enable-external-applications" I think this is dead.

5 years, 3 months ago (2015-09-15 09:28:01 UTC) #2

ppi

https://codereview.chromium.org/1343933003/diff/1/mojo/devtools/common/mojo_run File mojo/devtools/common/mojo_run (right): https://codereview.chromium.org/1343933003/diff/1/mojo/devtools/common/mojo_run#newcode20 mojo/devtools/common/mojo_run:20: "--enable-external-applications" On 2015/09/15 09:28:01, qsr wrote: > I think ...

5 years, 3 months ago (2015-09-15 09:28:41 UTC) #3

ppi

5 years, 3 months ago (2015-09-15 09:29:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fa3d04fd42c795a12aeaf07910b03e5708813e8b (presubmit successful).

Expand Messages | Collapse Messages