Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1343933002: Fix type Intersection and Maybe (Closed)

Created:
5 years, 3 months ago by neis
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Intersection of certain constants with bitsets was wrongly non-empty. R=jarin BUG= Committed: https://crrev.com/1328715977ea6a4f806349ec65f5a03567a129d0 Cr-Commit-Position: refs/heads/master@{#30790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -59 lines) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/types.h View 11 chunks +30 lines, -15 lines 0 comments Download
M src/types.cc View 11 chunks +39 lines, -44 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343933002/1
5 years, 3 months ago (2015-09-15 13:49:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 14:18:20 UTC) #4
Jarin
lgtm, but you are right - the code is on the verge of being unmaintainable. ...
5 years, 3 months ago (2015-09-16 21:23:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343933002/1
5 years, 3 months ago (2015-09-17 08:18:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 08:52:03 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 08:52:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1328715977ea6a4f806349ec65f5a03567a129d0
Cr-Commit-Position: refs/heads/master@{#30790}

Powered by Google App Engine
This is Rietveld 408576698