Issue 134393003: app_shell: Convert ExtensionsWebContentsObserver to BrowserContext from Profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134393003: app_shell: Convert ExtensionsWebContentsObserver to BrowserContext from Profile (Closed)

Created:
6 years, 11 months ago by James Cook

Modified:
6 years, 11 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

app_shell: Convert ExtensionsWebContentsObserver to BrowserContext from Profile And make it use ExtensionRegistry in one more place. It's used by ExtensionHost and this is a small step toward eliminating chrome dependencies. BUG=309909 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244418

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -18 lines)			Patch
M	chrome/browser/extensions/api/messaging/message_service.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/messaging/message_service.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_web_contents_observer.h	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_contents_observer.cc	View	5 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/134393003/1

6 years, 11 months ago (2014-01-11 00:22:23 UTC) #3

Message was sent while issue was closed.

Change committed as 244418

Expand Messages | Collapse Messages