Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: components/search_provider_logos/logo_tracker.h

Issue 1343913002: Introduce Animated Logo to Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lots of renamings Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/logo_tracker.h
diff --git a/components/search_provider_logos/logo_tracker.h b/components/search_provider_logos/logo_tracker.h
index 29933eb611093bd6d0ce52b90d87e3aedee98634..475608541755ba965889201c5c878f1c0151d06b 100644
--- a/components/search_provider_logos/logo_tracker.h
+++ b/components/search_provider_logos/logo_tracker.h
@@ -120,6 +120,7 @@ class LogoTracker : public net::URLFetcherDelegate {
// |wants_cta| determines if the url should return a call to action image.
// Note: |parse_logo_response_func| and |append_queryparams_func| must be
// suitable for running multiple times, concurrently, and on multiple threads.
+ // TODO(ianwen): remove wants_cta from parameter.
justincohen 2015/09/24 20:20:48 Does this mean GoogleAppendQueryparamsToLogoURL wi
newt (away) 2015/09/24 20:45:18 Yes, that's the plan. Sound good?
void SetServerAPI(const GURL& logo_url,
const ParseLogoResponse& parse_logo_response_func,
const AppendQueryparamsToLogoURL& append_queryparams_func,

Powered by Google App Engine
This is Rietveld 408576698