Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: components/search_provider_logos/logo_tracker.h

Issue 1343913002: Introduce Animated Logo to Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: respond to newt's comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/logo_tracker.h
diff --git a/components/search_provider_logos/logo_tracker.h b/components/search_provider_logos/logo_tracker.h
index 29933eb611093bd6d0ce52b90d87e3aedee98634..3266ea27ace21dee4f83a25349f1357578da9367 100644
--- a/components/search_provider_logos/logo_tracker.h
+++ b/components/search_provider_logos/logo_tracker.h
@@ -72,6 +72,7 @@ typedef base::Callback<
// Encodes the fingerprint of the cached logo in the logo URL. This enables the
// server to verify whether the cached logo is up-to-date.
+// TODO(ianwen): remove wants_cta from parameter.
newt (away) 2015/09/23 20:38:44 I approve of this TODO, but it's in the wrong plac
Ian Wen 2015/09/23 21:59:52 Done.
typedef base::Callback<GURL(const GURL& logo_url,
const std::string& fingerprint,
bool wants_cta)> AppendQueryparamsToLogoURL;

Powered by Google App Engine
This is Rietveld 408576698