third_party/gif_player/README.chromium - Issue 1343913002: Introduce Animated Logo to Chrome on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/gif_player/README.chromium

Issue 1343913002: Introduce Animated Logo to Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 Name: GifPlayer Library for Showing Gif on Android
	newt (away) 2015/09/18 20:46:03 Is this an established name taken from somewhere e Is this an established name taken from somewhere else? If not how about "GifPlayer Animated GIF Library" or simply "GifPlayer"? Everything in third_party is a "library" of sorts, so it's fine to remove "library" from the name. Ian Wen 2015/09/22 21:39:06 Done. Show quoted text On 2015/09/18 20:46:03, newt wrote: > Is this an established name taken from somewhere else? If not how about > "GifPlayer Animated GIF Library" or simply "GifPlayer"? Everything in > third_party is a "library" of sorts, so it's fine to remove "library" from the > name. Done.
	2 Short Name: GifPlayer Library

	3 URL: http://android-gifview.googlecode.com/svn/!svn/bc/8/trunk/

	4 Version: r8

	5 License: Apache License 2.0

	6 Security Critical: yes

	7 License Android Compatible: yes

	8

	9 Description:

	10 The GifDrawable library is a partial library built from the GifDecoder of
	newt (away) 2015/09/18 20:46:03 The first sentence should mention the purpose of t The first sentence should mention the purpose of this library (and use the right name): "GifPlayer allows animated GIFs to be displayed in Android's native view system." Then explain where it's from. Ian Wen 2015/09/22 21:39:06 Done. Show quoted text On 2015/09/18 20:46:03, newt wrote: > The first sentence should mention the purpose of this library (and use the right > name): "GifPlayer allows animated GIFs to be displayed in Android's native view > system." > > Then explain where it's from. Done.
	11 android-gifview which was originally created by tomorrowkey@gmail.com. We

	12 took the algorithm to add gif animation for android and adapted the algorithm

	13 as a Drawable.

	14

	15 Local Modifications:

	16 * Derived BaseGifDrawable.java and BaseGifImage.java from the original

	17 GifDecoder.java.

	18 * Removed GifDecoder.java as it is no longer needed (it served only as the

	19 pristine source file for the two derived files).

OLD	NEW

« third_party/gif_player/BUILD.gn ('K') | « third_party/gif_player/OWNERS ('k') | third_party/gif_player/gif_player.gyp » ('j') | no next file with comments »