third_party/gif_player/BUILD.gn - Issue 1343913002: Introduce Animated Logo to Chrome on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/gif_player/BUILD.gn

Issue 1343913002: Introduce Animated Logo to Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/android/rules.gni")	5 import("//build/config/android/rules.gni")

6	6

7 assert(is_android)	7 android_library("gif_player_java") {

8

9 android_library("android_swipe_refresh_java") {

10 DEPRECATED_java_in_dir = "java/src"

11 deps = [	8 deps = [

12 "//third_party/android_tools:android_support_v13_java",	9 "//base:base_java",
	newt (away) 2015/09/18 20:46:03 Why do these depend on base_java? The gyp target d Why do these depend on base_java? The gyp target doesn't depend on base_java. Ian Wen 2015/09/22 21:39:06 Removed the dependency. Show quoted text On 2015/09/18 20:46:03, newt wrote: > Why do these depend on base_java? The gyp target doesn't depend on base_java. Removed the dependency.
	10 ]

	11 java_files = [

	12 "src/jp/tomorrowkey/android/gifplayer/BaseGifDrawable.java",

	13 "src/jp/tomorrowkey/android/gifplayer/BaseGifImage.java",

13 ]	14 ]

14 }	15 }

OLD	NEW