Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: test/unittests/atomic-utils-unittest.cc

Issue 1343883004: Add barriers to atomic utils. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix test expectations Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/atomic-utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/atomic-utils-unittest.cc
diff --git a/test/unittests/atomic-utils-unittest.cc b/test/unittests/atomic-utils-unittest.cc
index a0d8a6a5085326248f3030294557baf0246becc3..ad33853d58bc6c248cd3e3ef9e71d694b9cf7379 100644
--- a/test/unittests/atomic-utils-unittest.cc
+++ b/test/unittests/atomic-utils-unittest.cc
@@ -86,7 +86,7 @@ TEST(AtomicValue, TrySetValue) {
TEST(AtomicValue, SetValue) {
AtomicValue<TestFlag> a(kB);
- EXPECT_EQ(kB, a.SetValue(kC));
+ a.SetValue(kC);
EXPECT_EQ(TestFlag::kC, a.Value());
}
@@ -95,7 +95,7 @@ TEST(AtomicValue, WithVoidStar) {
AtomicValue<void*> a(nullptr);
AtomicValue<void*> dummy(nullptr);
EXPECT_EQ(nullptr, a.Value());
- EXPECT_EQ(nullptr, a.SetValue(&a));
+ a.SetValue(&a);
EXPECT_EQ(&a, a.Value());
EXPECT_FALSE(a.TrySetValue(nullptr, &dummy));
EXPECT_TRUE(a.TrySetValue(&a, &dummy));
« no previous file with comments | « src/atomic-utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698