Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1343883004: Add barriers to atomic utils. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add barriers to atomic utils. Loads get an acquire, store/cas a release. Increment gets a full barrier. R=hpayer@chromium.org BUG= Committed: https://crrev.com/4d6c4a3e22dadaab89a1fded92a0423b1ca9f035 Cr-Commit-Position: refs/heads/master@{#30751}

Patch Set 1 #

Patch Set 2 : Fix test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M src/atomic-utils.h View 4 chunks +10 lines, -12 lines 0 comments Download
M test/unittests/atomic-utils-unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Lippautz
PTAl; this should meet our expectations now
5 years, 3 months ago (2015-09-15 13:49:22 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-15 14:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343883004/1
5 years, 3 months ago (2015-09-15 14:06:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/9621)
5 years, 3 months ago (2015-09-15 14:10:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343883004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343883004/20001
5 years, 3 months ago (2015-09-15 14:20:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 14:58:52 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 14:59:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d6c4a3e22dadaab89a1fded92a0423b1ca9f035
Cr-Commit-Position: refs/heads/master@{#30751}

Powered by Google App Engine
This is Rietveld 408576698